[PATCH] lib: fix clang compiler warning
authorJani Nikula <jani@nikula.org>
Fri, 17 Jan 2014 16:21:05 +0000 (18:21 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:59:04 +0000 (09:59 -0800)
62/f7fd3205b9b6d833fca9c6ac941d581fb85c88 [new file with mode: 0644]

diff --git a/62/f7fd3205b9b6d833fca9c6ac941d581fb85c88 b/62/f7fd3205b9b6d833fca9c6ac941d581fb85c88
new file mode 100644 (file)
index 0000000..ca883e9
--- /dev/null
@@ -0,0 +1,86 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6FF4B431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Jan 2014 08:21:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PX+kUzqR4IcJ for <notmuch@notmuchmail.org>;\r
+       Fri, 17 Jan 2014 08:21:09 -0800 (PST)\r
+Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com\r
+ [74.125.83.50])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ BA033431FB6   for <notmuch@notmuchmail.org>; Fri, 17 Jan 2014 08:21:08 -0800\r
+ (PST)\r
+Received: by mail-ee0-f50.google.com with SMTP id d17so2204775eek.37\r
+       for <notmuch@notmuchmail.org>; Fri, 17 Jan 2014 08:21:07 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:cc:subject:date:message-id;\r
+       bh=qg6eYdNMaJR+3/6JErpKwi1+X56xhm2zNwOf9XbG0Kk=;\r
+       b=VHxhz5PEpN/fIHtahcBd5Lg+t0FBMsTxrOctjW2Hyo9wP7yMgJrjIt8rduOuafz+1S\r
+       SCqvavgx+StIRFu4gcHbZoijnJi3GkBDoWoV9zDNbQ73kHRRXcWCYrpyL/C7Rrn1eimZ\r
+       hbUo8GfNW1+sD6Bf8y14JaMxWmZ9zK4ykCUMaJjMNOu46f4ppyGq+59HqZtVN0aZVq4n\r
+       p5t0VsamHqse0dSlO6cXJBQ0rp1p3gUT4mpae+MGIJ80tp+VxkpdlNcvX/fbQWsXeGbr\r
+       95A4T4uB0VdZoShauPgr1nT2MRH8o9REPWQk9Jzs3Txvy1RtC/jwyGmoveZK+0/TmSB/\r
+       OjAg==\r
+X-Gm-Message-State:\r
+ ALoCoQnQZD8aUmFBLQPhka0YBh1SmrZ4lqnew2gvwfSIl0+hpjwukvbXK18rGiqIxziQciHI/UjD\r
+X-Received: by 10.15.26.6 with SMTP id m6mr3555799eeu.80.1389975667683;\r
+       Fri, 17 Jan 2014 08:21:07 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91])\r
+       by mx.google.com with ESMTPSA id v7sm28087011eel.2.2014.01.17.08.21.06\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Fri, 17 Jan 2014 08:21:06 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] lib: fix clang compiler warning\r
+Date: Fri, 17 Jan 2014 18:21:05 +0200\r
+Message-Id: <1389975665-13962-1-git-send-email-jani@nikula.org>\r
+X-Mailer: git-send-email 1.8.5.2\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 17 Jan 2014 16:21:15 -0000\r
+\r
+With some combination of clang and talloc, not using the return value\r
+of talloc_steal() produces a warning. Ignore it, as talloc_steal() has\r
+no failure modes per documentation.\r
+---\r
+ lib/thread.cc | 2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/lib/thread.cc b/lib/thread.cc\r
+index 4dcf705..8f53e12 100644\r
+--- a/lib/thread.cc\r
++++ b/lib/thread.cc\r
+@@ -524,7 +524,7 @@ _notmuch_thread_create (void *ctx,\r
+     _resolve_thread_relationships (thread);\r
\r
+     /* Commit to returning thread. */\r
+-    talloc_steal (ctx, thread);\r
++    (void) talloc_steal (ctx, thread);\r
\r
+   DONE:\r
+     talloc_free (local);\r
+-- \r
+1.8.5.2\r
+\r