Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

diff --git a/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96 b/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96
new file mode 100644 (file)
index 0000000..561e628
--- /dev/null
+++ b/99/a7bfa55c2b67b09a1724cc72ce7777ef162e96
@@ -0,0 +1,110 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 489FD431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 11:40:10 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xEaCaWpCMIBe for <notmuch@notmuchmail.org>;\r
+       Sun, 26 Jan 2014 11:40:05 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E008F431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 26 Jan 2014 11:40:04 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1W7VYb-0006LD-K0; Sun, 26 Jan 2014 19:40:02 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1W7VXi-0001zj-9m; Sun, 26 Jan 2014 19:38:54 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el\r
+In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet>\r
+References: <87y5sipcjn.fsf@qmul.ac.uk>\r
+       <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bnyzoqq9.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 26 Jan 2014 19:37:27 +0000\r
+Message-ID: <8738kaa614.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 3e56a99d089b22c434adc8aa9d4d0bf0 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 26 Jan 2014 19:40:10 -0000\r
+\r
+\r
+I don't have anything older than 23.4 anymore so I am afraid I can't\r
+test. My recollection is that I upgraded to 23.4 the problem went away\r
+so I forgot about it. \r
+\r
+(I couldn't see easily what version of emacs debian stable has now as\r
+seemed to be called 45.)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Sat, 25 Jan 2014, David Bremner <david@tethera.net> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> ido-completing-read is used in notmuch-mua.el without any\r
+>> initialization.  This should work but a bug (emacs bug #3247) in some\r
+>> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs\r
+>> to get stuck in the mini-buffer. This tests to see if ido-mode has\r
+>> been initialized and if not calls it. This avoids the bug for these\r
+>> older versions of emacs.\r
+>>\r
+>> This is the only place that ido-completing-read is used so an alternative \r
+>> would be to replace ido-completing-read by completing-read but cworth \r
+>> expressed a preference for the ido version in \r
+>> id:"87wrhfvk6a.fsf@yoom.home.cworth.\r
+>\r
+> This patch was tagged wip, but then there was no progress ;).  It still\r
+> applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor\r
+> emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can\r
+> confirm it actually fixes the bug there.\r
+>\r
+> I propose we either apply the patch or ::wontfix the bug.\r
+>\r
+> cheers,\r
+>\r
+> d\r