--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 3BFE7431FBD\r
+ for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 23:49:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id nG9ZHu96khMX for <notmuch@notmuchmail.org>;\r
+ Wed, 12 Feb 2014 23:49:48 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
+ [18.7.68.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id 86CDB431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 23:49:48 -0800 (PST)\r
+X-AuditID: 12074422-f79526d000000c47-d0-52fc791ba2c6\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+ (using TLS with cipher AES256-SHA (256/256 bits))\r
+ (Client did not present a certificate)\r
+ by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 7B.EF.03143.B197CF25; Thu, 13 Feb 2014 02:49:47 -0500 (EST)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+ by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id s1D7nlUT005891; \r
+ Thu, 13 Feb 2014 02:49:47 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s1D7njKj030365\r
+ (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+ Thu, 13 Feb 2014 02:49:46 -0500\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1WDr3I-0004i2-MB; Thu, 13 Feb 2014 02:49:44 -0500\r
+Date: Thu, 13 Feb 2014 02:49:44 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH 1/1] emacs: always write emacs/.eldeps when the target is\r
+ remade\r
+Message-ID: <20140213074944.GY4375@mit.edu>\r
+References: <1390645309-2326-1-git-send-email-tomi.ollila@iki.fi>\r
+ <20140213071026.GX4375@mit.edu> <m2sirn1nik.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <m2sirn1nik.fsf@guru.guru-group.fi>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0ZWu/BNksKrR1uL6zZnMFm9WzmN1\r
+ YPI4/HUhi8ezVbeYA5iiuGxSUnMyy1KL9O0SuDL+fdYvmCFa0bX/J0sD432BLkZODgkBE4nD\r
+ T28zQdhiEhfurWfrYuTiEBKYzSSxfvpDdghnI6PExLVfwaqEBE4zSTTczIFILGGU6FizhBkk\r
+ wSKgKvFwUSMLiM0moCGxbf9yRhBbREBF4kHbelYQm1lAWuLb72awQcICYRIzF50G6+UV0JY4\r
+ vXceK8TQTkaJy1ffQyUEJU7OfMIC0awlcePfS6BmDrBBy/9xgIQ5BQwkbpyeCzZfFGjXlJPb\r
+ 2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdE31cjNL9FJTSjcxgsPa\r
+ RWkH48+DSocYBTgYlXh4NWb8DhJiTSwrrsw9xCjJwaQkynuk/E+QEF9SfkplRmJxRnxRaU5q\r
+ 8SFGCQ5mJRFeGQmgHG9KYmVValE+TEqag0VJnLfW4leQkEB6YklqdmpqQWoRTFaGg0NJgvcK\r
+ yFDBotT01Iq0zJwShDQTByfIcB6g4ftBaniLCxJzizPTIfKnGBWlxHlFQBICIImM0jy4Xlja\r
+ ecUoDvSKMO91kCoeYMqC634FNJgJaHBq1G+QwSWJCCmpBsbm4CiFzo+81otuP2qXmPCaS7Aj\r
+ 54DA26h+njnsVg5Sp/kr9zjH7FvG7LddhHf3tLCtvmJFblvryzpSn5TV/Xn3K2O/5zEPi0J2\r
+ U93w0JvnGo782XZzyiqeBTdSzwnNCXZaOn3jUxnxhG/1pWLxPA7xsx662FX+l5mctSQ+yzWT\r
+ cf+rLl/xuUosxRmJhlrMRcWJALJ6dn0WAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 13 Feb 2014 07:49:54 -0000\r
+\r
+Quoth Tomi Ollila on Feb 13 at 9:26 am:\r
+> On Thu, Feb 13 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> \r
+> > Quoth Tomi Ollila on Jan 25 at 12:21 pm:\r
+> >> So that the target is newer than its prerequisites.\r
+> >> ---\r
+> >> emacs/Makefile.local | 3 +--\r
+> >> 1 file changed, 1 insertion(+), 2 deletions(-)\r
+> >> \r
+> >> diff --git a/emacs/Makefile.local b/emacs/Makefile.local\r
+> >> index 42bfbd9..d5d402e 100644\r
+> >> --- a/emacs/Makefile.local\r
+> >> +++ b/emacs/Makefile.local\r
+> >> @@ -32,8 +32,7 @@ emacs_bytecode = $(emacs_sources:.el=.elc)\r
+> >> ifeq ($(HAVE_EMACS),1)\r
+> >> $(dir)/.eldeps: $(dir)/Makefile.local $(dir)/make-deps.el $(emacs_sources)\r
+> >> $(call quiet,EMACS) --directory emacs -batch -l make-deps.el \\r
+> >> - -f batch-make-deps $(emacs_sources) > $@.tmp && \\r
+> >> - (cmp -s $@.tmp $@ || mv $@.tmp $@)\r
+> >> + -f batch-make-deps $(emacs_sources) > $@.tmp && mv $@.tmp $@\r
+> >> -include $(dir)/.eldeps\r
+> >> endif\r
+> >> CLEAN+=$(dir)/.eldeps $(dir)/.eldeps.tmp\r
+> >\r
+> > Is this just so the rule doesn't get run again on the next make\r
+> > invocation (unless, of course, a dependent changed)?\r
+> \r
+> Basically yes. I did multiple builds in rapid succession when developing\r
+> something and this thing confused me quite a lot in the beginning...\r
+> \r
+> > Interestingly, if any of the dependents have changed, but in ways that\r
+> > don't affect .eldeps, this change will make the build more expensive\r
+> > because it will trigger a make restart after .eldeps is updated.\r
+> \r
+> I wondered what was the reason for the recipe you've chosen here, has\r
+> it something to do with inodes or something ;) (and were going to ask\r
+> an alternative to touch (or even : > $@) the target...\r
+> \r
+> ... but now I understand. E.g. change in notmuch-lib.el will cause *all* \r
+> .el files to be re-bytecompiled after this change. \r
+\r
+This is unrelated to the cmp in the recipe. A change in\r
+notmuch-lib.el *must* cause almost all .el files to be recompiled\r
+because they almost all require it and may use macros from it. If you\r
+touch, e.g., notmuch-hello.el, you'll see that very little is rebuilt\r
+(with or without this patch).\r
+\r
+> An alternative to this patch would be adding a message to the rule\r
+> which informs user to touch .eldeps to avoid re-doing .eldeps if\r
+> that irritates one :D\r
+> \r
+> something like:\r
+> \r
+> (cmp -s $@.tmp $@ && \\r
+> echo "touch $@ to avoid redoing this target" || mv $@.tmp $@)\r
+\r
+I think this patch is good as it is; I was just pointing out that the\r
+change also has a performance drawback in some situations. (Knowing\r
+make, there's probably *some* way to get the best of both worlds and\r
+it's probably really ugly.)\r
+\r
+> Thanks, \r
+> \r
+> Tomi\r
projects / notmuch-archives.git / commitdiff