t/README: Add a note about the dangers of coverage chasing
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Sun, 25 Jul 2010 19:52:45 +0000 (19:52 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 18 Aug 2010 19:42:37 +0000 (12:42 -0700)
Having no coverage at all is almost always a bad sign, but trying to
attain 100% coverage everywhere is usually a waste of time. Add a
paragraph to explain this to future test writers.

Inspired-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/README

index 468876de0d3db10d7c6b39fcade93ad998f2d0a2..e49534a1bf48017b48eaf8a93f6b7c226dad8c98 100644 (file)
--- a/t/README
+++ b/t/README
@@ -271,6 +271,15 @@ Do:
  - Check the test coverage for your tests. See the "Test coverage"
    below.
 
+   Don't blindly follow test coverage metrics, they're a good way to
+   spot if you've missed something. If a new function you added
+   doesn't have any coverage you're probably doing something wrong,
+   but having 100% coverage doesn't necessarily mean that you tested
+   everything.
+
+   Tests that are likely to smoke out future regressions are better
+   than tests that just inflate the coverage metrics.
+
 Don't:
 
  - exit() within a <script> part.