Re: [PATCH 1/5] cli: Refactor option passing in the search command

diff --git a/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8 b/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8
new file mode 100644 (file)
index 0000000..89d2114
--- /dev/null
+++ b/4e/7a8e5184b78714477d9f0d89a5220c1301a3f8
@@ -0,0 +1,87 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 11A6F431FCF\r
+       for <notmuch@notmuchmail.org>; Mon, 29 Sep 2014 10:28:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NZDZEZm7LkeW for <notmuch@notmuchmail.org>;\r
+       Mon, 29 Sep 2014 10:28:36 -0700 (PDT)\r
+Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com\r
+ [74.125.82.49])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 89CD4431FD4   for <notmuch@notmuchmail.org>; Mon, 29 Sep 2014 10:28:31 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f49.google.com with SMTP id x12so895719wgg.20\r
+       for <notmuch@notmuchmail.org>; Mon, 29 Sep 2014 10:28:29 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=k5MpagCpAscibIZuRMzWeDcNsJGyBud/hvC1mND+TU8=;\r
+       b=C9/3diJI/KdhPB3jd+2c69gw+jXad0G1Cv1aEK58TvECXgrMMmY+a3Jj30yr6qenr6\r
+       vDnT+swHDdQZUUu8zShYXUrFr+iB4EfEZL94CexuPc4tkLqFL/tCzBP86H+KCREeUvaU\r
+       3p29CBiXMIpo7VYUqdKTWBzJWmGGUKdSqfCWocT8AnXlLFlOdIiAvDvqfyxQQJl/D6lY\r
+       aHz3HzGvLkLbUcLa05M5a5I8yRVxVB2n0CFGE2cvNQZySEsZUfjP4WTQm5lFIZyJx14w\r
+       RsoKfa1x6ZrvRlbzAWJPao/Xm83e32vr+IGrJkX7KE9JPOhmKic6SYUFs6qfRRA4IzCU\r
+       Vx+g==\r
+X-Gm-Message-State:\r
+ ALoCoQlLVNf+wlae3sdLxKeD1U9HCiIGnxvcaf2sYdwGB+PtxA3RnKpWd9m983iFIDesCKCU7lZk\r
+X-Received: by 10.180.81.195 with SMTP id c3mr38753895wiy.11.1412011709328;\r
+       Mon, 29 Sep 2014 10:28:29 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36c-245.dhcp.inet.fi.\r
+       [88.195.108.245]) by mx.google.com with ESMTPSA id\r
+       bt9sm16374207wjc.44.2014.09.29.10.28.28 for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Mon, 29 Sep 2014 10:28:28 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/5] cli: Refactor option passing in the search command\r
+In-Reply-To: <87k34rtoi2.fsf@steelpick.2x.cz>\r
+References: <1411378679-7307-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1411378679-7307-2-git-send-email-sojkam1@fel.cvut.cz>\r
+       <m27g0rpl6x.fsf@guru.guru-group.fi>\r
+       <87k34rtoi2.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 29 Sep 2014 20:28:26 +0300\r
+Message-ID: <874mvqxrnp.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 29 Sep 2014 17:28:44 -0000\r
+\r
+On Thu, 25 Sep 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> On Thu, Sep 25 2014, Tomi Ollila wrote:\r
+>> Although the test and the implementation in the next patches look OK, I'd\r
+>> prefer the FLAG implementation Jani suggested earlier. IMO now that I\r
+>> compare these two it looks cleaner and simpler...\r
+>\r
+> The question is which kind of simplicity you have in mind. I think that\r
+> my version is simpler to type (less keystrokes). But if others have\r
+> different opinion, I don't mind.\r
+\r
+I'm biased, but I do like the implementation simplicity of my\r
+approach. Adding the bash completion support is also trivial.\r
+\r
+BR,\r
+Jani.\r