Re: [PATCH 1/2] test: add more maildir flag syncing related tests to insert

diff --git a/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146 b/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146
new file mode 100644 (file)
index 0000000..493e914
--- /dev/null
+++ b/ed/61e11dae93dc2fc1b8a6f615a14dd29bacf146
@@ -0,0 +1,113 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 62E85431FDA\r
+       for <notmuch@notmuchmail.org>; Tue,  3 Sep 2013 05:11:35 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EPZ8G-PT8QGE for <notmuch@notmuchmail.org>;\r
+       Tue,  3 Sep 2013 05:11:29 -0700 (PDT)\r
+Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com\r
+ [74.125.83.48])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 1DD79431FD8   for <notmuch@notmuchmail.org>; Tue,  3 Sep 2013 05:11:29 -0700\r
+ (PDT)\r
+Received: by mail-ee0-f48.google.com with SMTP id l10so2899566eei.7\r
+       for <notmuch@notmuchmail.org>; Tue, 03 Sep 2013 05:11:28 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=Mn3UVdTPholh6ZevzRrezhUf+/b54sjia4MaWB6Wii8=;\r
+       b=Y4MQf5t73pdSSF04qwOgwxzZeLl7cm53VuN7T83qXHNz+VMRPoM/ET51RJXgCFj0pj\r
+       RfQ6e/+pNpAQB5/RVl2xJxnAI4U3h5dcPZqIzrxNRP1D7pW16ZzDmWHA1+dQ9jQwDlKu\r
+       EsaRAdr6XuxP/3lldZd4TCxAxK7APE5cN7xeAOqXVKvoq7+im4n+3po5OV+fXx3wL6+X\r
+       GMcAgsuSqXa/C0B1VNfIsKUj/poE2rhZXClfgZdFuy1MwyZt9cX3RpHMniTTApxQF6kC\r
+       lKopGVTm/pnAqW53EJNrtjVsIqSRHtsqyKHqsnsCQ7/+keFkCWqPRuMFSPV+bSWK+Oon\r
+       zncw==\r
+X-Gm-Message-State:\r
+ ALoCoQmKHPD6g6BdFIsSL779BimHW5ArypeJBk/tcdof9JWgabNA/0X2nfvqbgsFHyuFyLTl+WPR\r
+X-Received: by 10.14.175.2 with SMTP id y2mr435686eel.83.1378210286595;\r
+       Tue, 03 Sep 2013 05:11:26 -0700 (PDT)\r
+Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])\r
+       by mx.google.com with ESMTPSA id h52sm31018870eez.3.1969.12.31.16.00.00\r
+       (version=TLSv1.1 cipher=RC4-SHA bits=128/128);\r
+       Tue, 03 Sep 2013 05:11:24 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add more maildir flag syncing related tests to\r
+       insert\r
+In-Reply-To: <87mwnus1bg.fsf@zancas.localnet>\r
+References: <1378170613-3584-1-git-send-email-david@tethera.net>\r
+       <1378185543-25271-1-git-send-email-jani@nikula.org>\r
+       <87mwnus1bg.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+177~gb1ba76c (http://notmuchmail.org) Emacs/23.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 03 Sep 2013 14:11:12 +0200\r
+Message-ID: <87fvtmds0v.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 03 Sep 2013 12:11:35 -0000\r
+\r
+On Tue, 03 Sep 2013, David Bremner <david@tethera.net> wrote:\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>>  \r
+>> +test_begin_subtest "Insert message with default tags stays in new/"\r
+>> +gen_insert_msg\r
+>> +notmuch insert < "$gen_msg_filename"\r
+>> +output=$(notmuch search --output=files id:$gen_msg_id)\r
+>> +dirname=$(dirname "$output")\r
+>> +test_expect_equal "$dirname" "$MAIL_DIR/new"\r
+>\r
+> I'm not sure if this is a bug or a feature, but this enforces a\r
+> constraint on the default tags that notmuch ships enabled. Is that what\r
+> we want, or would it be better to set unread explicitely here?\r
+\r
+We already pretty heavily depend on those default tags, so I'd say just\r
+leave it like this. If we want to fix it later, there's some other\r
+fixing to do too. Try this patch and 'make test':\r
+\r
+diff --git a/notmuch-config.c b/notmuch-config.c\r
+index 6845e3c..8362c13 100644\r
+--- a/notmuch-config.c\r
++++ b/notmuch-config.c\r
+@@ -365,8 +365,8 @@ notmuch_config_open (void *ctx,\r
+     }\r
+ \r
+     if (notmuch_config_get_new_tags (config, &tmp) == NULL) {\r
+-        const char *tags[] = { "unread", "inbox" };\r
+-        notmuch_config_set_new_tags (config, tags, 2);\r
++        const char *tags[] = { "flagged" };\r
++        notmuch_config_set_new_tags (config, tags, 1);\r
+     }\r
+ \r
+     if (notmuch_config_get_new_ignore (config, &tmp) == NULL) {\r
+\r
+I get:\r
+\r
+Notmuch test suite complete.\r
+396/579 tests passed.\r
+183 tests failed.\r
+\r
+\r
+BR,\r
+Jani.\r