Re: [PATCH 10/11] emacs: Add known-broken tests for search tagging races

diff --git a/c9/5e41f0fa17813853a9503d1aa9e51864447429 b/c9/5e41f0fa17813853a9503d1aa9e51864447429
new file mode 100644 (file)
index 0000000..61111fe
--- /dev/null
+++ b/c9/5e41f0fa17813853a9503d1aa9e51864447429
@@ -0,0 +1,130 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 15064431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Oct 2013 09:49:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id svJ-H3Kn8jJu for <notmuch@notmuchmail.org>;\r
+       Tue,  8 Oct 2013 09:49:05 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 419DB431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  8 Oct 2013 09:49:05 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VTaSz-0006DC-3V; Tue, 08 Oct 2013 17:49:04 +0100\r
+Received: from 92.40.123.1.threembb.co.uk ([92.40.123.1] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VTaSx-0001dR-Fv; Tue, 08 Oct 2013 17:49:00 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 10/11] emacs: Add known-broken tests for search tagging\r
+       races\r
+In-Reply-To: <1381185201-25197-11-git-send-email-amdragon@mit.edu>\r
+References: <1381185201-25197-1-git-send-email-amdragon@mit.edu>\r
+       <1381185201-25197-11-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 08 Oct 2013 17:47:51 +0100\r
+Message-ID: <87txgraevc.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 92.40.123.1\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: bdadf64c4de06e38c4475b195cb32ab1 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Oct 2013 16:49:13 -0000\r
+\r
+\r
+On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> These tests check that both thread-local and global search tagging\r
+> operations are race-free.  They are currently known-broken because\r
+> they aren't race-free.\r
+> ---\r
+>  test/emacs | 26 ++++++++++++++++++++++++++\r
+>  1 file changed, 26 insertions(+)\r
+>\r
+> diff --git a/test/emacs b/test/emacs\r
+> index 2917189..e0dcd3c 100755\r
+> --- a/test/emacs\r
+> +++ b/test/emacs\r
+> @@ -922,4 +922,30 @@ This is a warning (see *Notmuch errors* for more details)\r
+>  This is a warning\r
+>  This is another warning"\r
+>  \r
+> +test_begin_subtest "Search thread tag operations are race-free"\r
+> +test_subtest_known_broken\r
+> +add_message '[subject]="Search race test"'\r
+> +gen_msg_id_1=$gen_msg_id\r
+> +generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \\r
+> +        '[references]="<'$gen_msg_id_1'>"' \\r
+> +        '[subject]="Search race test two"'\r
+> +test_emacs '(notmuch-search "subject:\"search race test\"")\r
+> +        (notmuch-test-wait)\r
+> +        (notmuch-poll)\r
+> +        (execute-kbd-macro "+search-thread-race-tag")'\r
+> +output=$(notmuch search --output=messages 'tag:search-thread-race-tag')\r
+> +test_expect_equal "$output" "id:$gen_msg_id_1"\r
+> +\r
+> +test_begin_subtest "Search global tag operations are race-free"\r
+> +test_subtest_known_broken\r
+> +generate_message '[in-reply-to]="<'$gen_msg_id_1'>"' \\r
+> +        '[references]="<'$gen_msg_id_1'>"' \\r
+> +        '[subject]="Re: Search race test"'\r
+> +test_emacs '(notmuch-search "subject:\"search race test\" -subject:two")\r
+> +        (notmuch-test-wait)\r
+> +        (notmuch-poll)\r
+> +        (execute-kbd-macro "*+search-global-race-tag")'\r
+> +output=$(notmuch search --output=messages 'tag:search-global-race-tag')\r
+> +test_expect_equal "$output" "id:$gen_msg_id_1"\r
+> +\r
+>  test_done\r
+\r
+For the global tagging test would it be worth also adding a matching\r
+message in a different thread?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+> -- \r
+> 1.8.4.rc3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r