Re: [PATCH v2 0/7] lib: replace the message header parser with gmime
authorJani Nikula <jani@nikula.org>
Sun, 2 Feb 2014 13:03:52 +0000 (15:03 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:59:32 +0000 (09:59 -0800)
b9/050038e05901390e2bb9e6bd110a288dbd5025 [new file with mode: 0644]

diff --git a/b9/050038e05901390e2bb9e6bd110a288dbd5025 b/b9/050038e05901390e2bb9e6bd110a288dbd5025
new file mode 100644 (file)
index 0000000..473bc88
--- /dev/null
@@ -0,0 +1,102 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 12375431FD5\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 05:04:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id wRmijV3GcbAQ for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Feb 2014 05:04:01 -0800 (PST)\r
+Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com\r
+ [74.125.83.41])       (using TLSv1 with cipher RC4-SHA (128/128 bits))        (No client\r
+ certificate requested)        by olra.theworths.org (Postfix) with ESMTPS id\r
+ 8BE77431FC0   for <notmuch@notmuchmail.org>; Sun,  2 Feb 2014 05:04:01 -0800\r
+ (PST)\r
+Received: by mail-ee0-f41.google.com with SMTP id e51so1121181eek.28\r
+       for <notmuch@notmuchmail.org>; Sun, 02 Feb 2014 05:04:00 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=kWDWVtPk2HyOBQyEZ5W6MBnaRRf6M75lxVpXjo4czzs=;\r
+       b=ZPnKUS4z1lC0ew+mQPIV0dkrwRgZMeY9Wr0YG7NfZCPXK8k5oipPwOCWaRp4KTckaw\r
+       +PUKr/sQk0CVi/S9zNKZl2/WLuLoc3slexyjITfmj9RoF+ReTv5Byf1Y0jPNVjnJlg9/\r
+       MPJmmmu5ySJun160CkBjeBBmhqtVJU9PMJSYzGMxO4J8gdarTb12Baq3O9ZgigmNBqdj\r
+       K+Z0729EFhrXZxnMECr6p2v2ElD//CVpImq6PNNmU53Hdtm2uPLy6J0ccXX6q3ItfSZl\r
+       T8YLtw3+gg+kC52O1e8KBUfQ6ur5ka9SgzNwPgjrLha0KftX3Y6qWekH11PH5uiL0EQ9\r
+       LDyg==\r
+X-Gm-Message-State:\r
+ ALoCoQm5pXGmraZ+Z/9Nsou/u0AIXuroVF2tNxoM7HUoHLP+VIn4z+lw8ufGpp/04bc4gmhDNMUg\r
+X-Received: by 10.14.101.5 with SMTP id a5mr1535202eeg.63.1391346240457;\r
+       Sun, 02 Feb 2014 05:04:00 -0800 (PST)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91]) by mx.google.com with ESMTPSA id\r
+       z49sm61810033eeo.10.2014.02.02.05.03.58 for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sun, 02 Feb 2014 05:03:59 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime\r
+In-Reply-To: <87ob3di0md.fsf@zancas.localnet>\r
+References: <cover.1385825425.git.jani@nikula.org>\r
+       <87ob3di0md.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17+44~ge3b4cd9 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 02 Feb 2014 15:03:52 +0200\r
+Message-ID: <871tzly8cn.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Feb 2014 13:04:09 -0000\r
+\r
+On Wed, 15 Jan 2014, David Bremner <david@tethera.net> wrote:\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish.\r
+>>\r
+>> Patches 1-4 do prep work to fix some of the differences in the parsers\r
+>> in advance. Arguably they are not that bad regardless of the parser\r
+>> change.\r
+>>\r
+>> Patches 5-6 actually make the change. Having two patches is a somewhat\r
+>> artificial division, but perhaps makes it easier to review.\r
+>>\r
+>\r
+> I had a quick look at these changes, and nothing jumped out at me. I'd\r
+> appreciate a second pair of eyes on them.\r
+\r
+Anyone?\r
+\r
+Patches 1-4 are pretty straightforward prep work, IMHO useful on their\r
+own too. It would help just to get them reviewed and merged first.\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+> I ran the performance suite, and there is only one message (in version\r
+> 0.4 of the corpus) newly classified as non-mail. Of course I did clean\r
+> up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes\r
+> in performance before and after the patches. I only had patience enough\r
+> to run twice in both cases.\r
+>\r
+> d\r