--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0F3A2431FC2\r
+ for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 13:45:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id shKk7to4iLk0 for <notmuch@notmuchmail.org>;\r
+ Wed, 29 Oct 2014 13:45:09 -0700 (PDT)\r
+Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com\r
+ [209.85.212.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id B442B431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 13:45:09 -0700 (PDT)\r
+Received: by mail-wi0-f177.google.com with SMTP id ex7so5692978wid.16\r
+ for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 13:45:08 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+ :user-agent:date:message-id:mime-version:content-type;\r
+ bh=SVKru4Azns5MQ5g6p1U6Cdf8+hNkM/wPcqhApBnQu1E=;\r
+ b=OkNBAfypXVjfIQBcWKa/T6tPKffCXLCwLqA+6/V/xZXZkIMAenDIKf1wJedL8tssVk\r
+ 46pBWiE90tO5XQOy+MBTIw6YS9tY0jvK2rBhHLZvbqDYXd0cqKQzrIelJo4S1dDpRLoZ\r
+ YF8VcIAH9TyN1dFYfaBIaGWJyvjT8YUk5JfXNbIl6MVmMuhXDo+k9oQb/OhBy5J5yRQk\r
+ Aka0zYxfiR2L4wDORqvflq0uNfQ9EsiNPd6bMLfRWSjP2jOXYb8hB8Rfjgi0yZXmNCfC\r
+ hVYO34isgj5RsaFp1AxZATB1354phv3Na1gmb9x/ANZAuEEqYONeD+4kGYjE28qXdEID\r
+ /tGQ==\r
+X-Gm-Message-State:\r
+ ALoCoQnw6qprKYqc4ecLw72/lL0x+YM1DDe0UKT4SOyvRLHy/nXtH0vGObf1cH8cyoB7WLs/cu4p\r
+X-Received: by 10.180.104.99 with SMTP id gd3mr15085080wib.10.1414615508357;\r
+ Wed, 29 Oct 2014 13:45:08 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36d-48.dhcp.inet.fi.\r
+ [88.195.109.48])\r
+ by mx.google.com with ESMTPSA id eu8sm15030747wic.1.2014.10.29.13.45.07\r
+ for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Wed, 29 Oct 2014 13:45:07 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add stash support for git send-email command line\r
+In-Reply-To: <m2h9yn6zf1.fsf@dme.org>\r
+References: <1414525138-838-1-git-send-email-jani@nikula.org>\r
+ <m2h9yn6zf1.fsf@dme.org>\r
+User-Agent: Notmuch/0.18.2+148~g4214adf (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 29 Oct 2014 22:45:05 +0200\r
+Message-ID: <87y4ryzju6.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 20:45:18 -0000\r
+\r
+On Wed, 29 Oct 2014, David Edmondson <dme@dme.org> wrote:\r
+> On Tue, Oct 28 2014, Jani Nikula wrote:\r
+>> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as\r
+>> --in-reply-to, suitable for pasting to git send-email command line.\r
+>> ---\r
+>> emacs/notmuch-show.el | 25 +++++++++++++++++++++++++\r
+>> 1 file changed, 25 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index a9974826e824..328c93ba0584 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1274,6 +1274,7 @@ reset based on the original query."\r
+>> (define-key map "t" 'notmuch-show-stash-to)\r
+>> (define-key map "l" 'notmuch-show-stash-mlarchive-link)\r
+>> (define-key map "L" 'notmuch-show-stash-mlarchive-link-and-go)\r
+>> + (define-key map "G" 'notmuch-show-stash-git-send-email)\r
+>> (define-key map "?" 'notmuch-subkeymap-help)\r
+>> map)\r
+>> "Submap for stash commands")\r
+>> @@ -2125,6 +2126,30 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."\r
+>> (notmuch-show-stash-mlarchive-link mla)\r
+>> (browse-url (current-kill 0 t)))\r
+>> \r
+>> +(defun notmuch-show-stash-git-helper (addresses prefix)\r
+>> + "Escape, trim, and add PREFIX to each address in list of ADDRESSES."\r
+>> + (when addresses\r
+>> + (mapconcat (lambda (x)\r
+>> + (concat prefix "\""\r
+>> + ;; escape double-quotes\r
+>> + (replace-regexp-in-string\r
+>> + "\"" "\\\\\""\r
+>> + ;; trim leading and trailing spaces\r
+>> + (replace-regexp-in-string\r
+>> + "\\(^ *\\| *$\\)" ""\r
+>> + x)) "\" "))\r
+>> + addresses "")))\r
+>\r
+> This doesn't seem quite right. You leave a spurious trailing\r
+> space. Maybe that's because you need it in the following function to\r
+> separate the from/to/cc elements? That kind of interaction between the\r
+> two functions is icky.\r
+\r
+Agreed, thanks for pointing it out.\r
+\r
+> There's no need to test `addresses' at the head of the list - mapconcat\r
+> is fine with nil.\r
+>\r
+> How about:\r
+>\r
+> (defun notmuch-show-stash-git-helper (addresses prefix)\r
+> "Escape, trim, and add PREFIX to each address in list of ADDRESSES."\r
+> (mapconcat (lambda (x)\r
+> (concat prefix "\""\r
+> ;; escape double-quotes\r
+> (replace-regexp-in-string\r
+> "\"" "\\\\\""\r
+> ;; trim leading and trailing spaces\r
+> (replace-regexp-in-string\r
+> "\\(^ *\\| *$\\)" ""\r
+> x)) "\""))\r
+> addresses " "))\r
+>\r
+> This would remove the trailing space, so...\r
+>\r
+>> +\r
+>> +(defun notmuch-show-stash-git-send-email ()\r
+>> + "Copy From/To/Cc/Message-Id of current message to kill-ring in a form suitable for pasting to git send-email command line."\r
+>> + (interactive)\r
+>> + (notmuch-common-do-stash\r
+>> + (concat\r
+>> + (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-from)) "--to=")\r
+>> + (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-to)) "--to=")\r
+>> + (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-cc)) "--cc=")\r
+>> + (concat "--in-reply-to=\"" (notmuch-show-get-message-id t) "\""))))\r
+>\r
+> ...this would have to use something like:\r
+>\r
+> (mapconcat 'identity (list\r
+> (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-from)) "--to=")\r
+> (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-to)) "--to=")\r
+> (notmuch-show-stash-git-helper (message-tokenize-header (notmuch-show-get-cc)) "--cc=")\r
+> (concat "--in-reply-to=\"" (notmuch-show-get-message-id t) "\""))\r
+> "")\r
+>\r
+> to separate the chunks (untested).\r
+\r
+The last "" has to be " " to separate the elements, but this brings\r
+another small wrinkle: if one of the headers is missing, typically Cc:,\r
+it will be nil in the list, and mapconcat adds spaces both sides of\r
+that, i.e. double space. Any ideas how to fix that?\r
+\r
+> Could you avoid the double-quote quoting by using single quotes inside\r
+> the strings?\r
+\r
+The addresses may contain both single quotes and double quotes, so\r
+escaping either of them seems like the only option.\r
+\r
+> Do the leading and trailing spaces really matter?\r
+\r
+Does aesthetically displeasing count? Because message-tokenize-header\r
+splits using "," but headers typically have ", " between addresses, the\r
+end result will practically always have --to=" user@example.com" without\r
+the trimming.\r
+\r
+Thanks for the helpful review; I'm not much of a lisp coder...\r
+\r
+BR,\r
+Jani.\r
+\r
+\r
+>\r
+> (Domo: Look, I managed to write 'separate', twice!)\r
+>\r
+>> +\r
+>> ;; Interactive part functions and their helpers\r
+>> \r
+>> (defun notmuch-show-generate-part-buffer (message-id nth)\r
+>> -- \r
+>> 2.1.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff