Re: [PATCH v2 0/9] emacs: Unify common key bindings and lots more

diff --git a/c3/24250e814c7c02bd9b1983b3f029c0af5482ab b/c3/24250e814c7c02bd9b1983b3f029c0af5482ab
new file mode 100644 (file)
index 0000000..d0321ae
--- /dev/null
+++ b/c3/24250e814c7c02bd9b1983b3f029c0af5482ab
@@ -0,0 +1,142 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39A13431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Sep 2013 09:59:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id abrW0OqZf7Uj for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Sep 2013 09:59:50 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C96F9431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Sep 2013 09:59:47 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 42A51100090;\r
+       Mon,  9 Sep 2013 19:59:41 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/9] emacs: Unify common key bindings and lots more\r
+In-Reply-To: <1378244725-18846-1-git-send-email-amdragon@mit.edu>\r
+References: <1378244725-18846-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16+68~g2e5340c (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 09 Sep 2013 19:59:40 +0300\r
+Message-ID: <m2ob82ue0z.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Sep 2013 16:59:58 -0000\r
+\r
+On Wed, Sep 04 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> This is v2 of id:1377793557-28878-1-git-send-email-amdragon@mit.edu.\r
+> This fixes a problem found by Jani where notmuch-hello would reset\r
+> point placement when refreshing in Emacs 24.  It also inverts the\r
+> sense of notmuch-hello-auto-refresh and makes it a defcustom\r
+> (originally I'd intended notmuch-hello-inhibit-auto-refresh for\r
+> internal use only, but both Mark and Jani expressed interest in\r
+> setting it).\r
+\r
+I've been using this patch series a few days now it has worked fine.\r
+It took me a while to grok the notmuch-hello-window-configuration-change\r
+which imo provides nice piece of functionality.\r
+\r
+The whole patch series LGTM.\r
+\r
+Tomi\r
+\r
+>\r
+> The diff from v1 follows\r
+>\r
+> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el\r
+> index 1d6c3a2..55c416a 100644\r
+> --- a/emacs/notmuch-hello.el\r
+> +++ b/emacs/notmuch-hello.el\r
+> @@ -232,6 +232,11 @@ supported for \"Customized queries section\" items."\r
+>          notmuch-hello-query-section\r
+>          (function :tag "Custom section"))))\r
+>=20=20\r
+> +(defcustom notmuch-hello-auto-refresh t\r
+> +  "Automatically refresh when returning to the notmuch-hello buffer."\r
+> +  :group 'notmuch-hello\r
+> +  :type 'boolean)\r
+> +\r
+>  (defvar notmuch-hello-hidden-sections nil\r
+>    "List of sections titles whose contents are hidden")\r
+>=20=20\r
+> @@ -478,9 +483,6 @@ Such a list can be computed with `notmuch-hello-query=\r
+-counts'."\r
+>    ;; Lazy - rebuild everything.\r
+>    (notmuch-hello no-display))\r
+>=20=20\r
+> -(defvar notmuch-hello-inhibit-auto-refresh nil\r
+> -  "Don't refresh notmuch-hello on window configuration changes.")\r
+> -\r
+>  (defun notmuch-hello-window-configuration-change ()\r
+>    "Hook function to update the hello buffer when it is switched to."\r
+>    (let ((hello-buf (get-buffer "*notmuch-hello*"))\r
+> @@ -501,8 +503,11 @@ Such a list can be computed with `notmuch-hello-quer=\r
+y-counts'."\r
+>          ;; is currently visible, was not visible on the last\r
+>          ;; configuration change, and this is not a new window)\r
+>          (setq do-refresh t)))))\r
+> -    (when (and do-refresh (not notmuch-hello-inhibit-auto-refresh))\r
+> -      (notmuch-hello t))\r
+> +    (when (and do-refresh notmuch-hello-auto-refresh)\r
+> +      ;; Refresh hello as soon as we get back to redisplay.  On Emacs\r
+> +      ;; 24, we can't do it right here because something in this\r
+> +      ;; hook's call stack overrides hello's point placement.\r
+> +      (run-at-time nil nil #'notmuch-hello t))\r
+>      (when (null hello-buf)\r
+>        ;; Clean up hook\r
+>        (remove-hook 'window-configuration-change-hook\r
+> @@ -785,14 +790,15 @@ following:\r
+>=20=20\r
+>    ;; This may cause a window configuration change, so if the\r
+>    ;; auto-refresh hook is already installed, avoid recursive refresh.\r
+> -  (let ((notmuch-hello-inhibit-auto-refresh t))\r
+> +  (let ((notmuch-hello-auto-refresh nil))\r
+>      (if no-display\r
+>      (set-buffer "*notmuch-hello*")\r
+>        (switch-to-buffer "*notmuch-hello*")))\r
+>=20=20\r
+>    ;; Install auto-refresh hook\r
+> -  (add-hook 'window-configuration-change-hook\r
+> -        #'notmuch-hello-window-configuration-change)\r
+> +  (when notmuch-hello-auto-refresh\r
+> +    (add-hook 'window-configuration-change-hook\r
+> +          #'notmuch-hello-window-configuration-change))\r
+>=20=20\r
+>    (let ((target-line (line-number-at-pos))\r
+>      (target-column (current-column))\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
+>\r
+\r
+--=20\r
+"kaik on m=C3=A4nt!"\r