Re: [PATCH] devel: add release-checks.sh
authorDavid Bremner <david@tethera.net>
Sun, 19 Aug 2012 14:03:03 +0000 (16:03 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:49:08 +0000 (09:49 -0800)
31/ba98831d5170781538be237cda4c4cf1d00611 [new file with mode: 0644]

diff --git a/31/ba98831d5170781538be237cda4c4cf1d00611 b/31/ba98831d5170781538be237cda4c4cf1d00611
new file mode 100644 (file)
index 0000000..3d14812
--- /dev/null
@@ -0,0 +1,72 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A673D431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 20 Aug 2012 00:18:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.804\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.804 tagged_above=-999 required=5\r
+       tests=[DATE_IN_PAST_12_24=0.804] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id a6AbsqZo+zwC for <notmuch@notmuchmail.org>;\r
+       Mon, 20 Aug 2012 00:18:09 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DEDE3431FC2\r
+       for <notmuch@notmuchmail.org>; Mon, 20 Aug 2012 00:18:08 -0700 (PDT)\r
+Received: from remotemail by tesseract.cs.unb.ca with local (Exim 4.72)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1T3MFT-0002Ea-DR; Mon, 20 Aug 2012 04:18:07 -0300\r
+Received: (nullmailer pid 24990 invoked by uid 1000);\r
+       Sun, 19 Aug 2012 14:03:03 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] devel: add release-checks.sh\r
+In-Reply-To: <1344456107-19308-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1344456107-19308-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.13.2+76~gac7b542 (http://notmuchmail.org) Emacs/24.1.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 19 Aug 2012 16:03:03 +0200\r
+Message-ID: <87y5lbkmi0.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 20 Aug 2012 07:18:11 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> Currently Makefile.local contains some machine executable release\r
+> checking functionality. This is unnecessarily complex way to do it:\r
+\r
+Hi Tomi;\r
+\r
+Overall this looks good, but there seems to be one minor bug:\r
+\r
+- If there are extra files under man/man1 (e.g. from "make\r
+  update-versions"), then the check "Checking that manual page dates and\r
+  versions" fails, even if it passes after running "git clean -fx"\r
+\r
+I don't really think this is a blocker, but on the other hand it isn't\r
+urgent to ship the patch either.\r
+\r
+Another piece of Makefile.local that isn't really "make" is\r
+"update-versions". On the other hand, it isn't nearly as long or\r
+complicated as the release checks.\r
+\r
+d\r