Re: [PATCH v1] emacs: Report a lack of matches when calling `notmuch-show'.

diff --git a/da/8eae0dc915cfdfcde6add1b952a6cfac065727 b/da/8eae0dc915cfdfcde6add1b952a6cfac065727
new file mode 100644 (file)
index 0000000..a4fb03f
--- /dev/null
+++ b/da/8eae0dc915cfdfcde6add1b952a6cfac065727
@@ -0,0 +1,114 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 01AFA6DE0A7F\r
+ for <notmuch@notmuchmail.org>; Sun,  7 Feb 2016 22:44:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.646\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.646 tagged_above=-999 required=5 tests=[AWL=-0.006,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id eJtjkV0G3Iry for <notmuch@notmuchmail.org>;\r
+ Sun,  7 Feb 2016 22:44:00 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id B0AA56DE0261\r
+ for <notmuch@notmuchmail.org>; Sun,  7 Feb 2016 22:43:59 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 215A510007F;\r
+ Mon,  8 Feb 2016 08:44:06 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, David Edmondson <dme@dme.org>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1] emacs: Report a lack of matches when calling\r
+ `notmuch-show'.\r
+In-Reply-To: <871t8onmnb.fsf@qmul.ac.uk>\r
+References: <1454782892-1690-1-git-send-email-dme@dme.org>\r
+ <1454782892-1690-2-git-send-email-dme@dme.org> <871t8onmnb.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 08 Feb 2016 08:44:05 +0200\r
+Message-ID: <m2wpqfn1l6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 08 Feb 2016 06:44:02 -0000\r
+\r
+On Mon, Feb 08 2016, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> On Sat, 06 Feb 2016, David Edmondson <dme@dme.org> wrote:\r
+>> If the basic query passed to `notmuch-show' generates no results,\r
+>> throw an error and inform the user that no messages matched the query\r
+>> rather than displaying an empty buffer and showing an obscure error.\r
+>\r
+> Hi\r
+>\r
+> First this is a clear improvement on the current behaviour, an I am\r
+> happy with it as is.\r
+>\r
+> However, I wonder if we actually want an error at all in this case,\r
+> rather than just a "message". I think some people run with\r
+> debug-on-error enabled and it might be annoying in that case (though\r
+> clearly less annoying than the current situation).\r
+\r
+Actually I got the same when testing\r
+\r
+(notmuch-show "id:nonexistent") M-x eval-print-last-sexp\r
+\r
+instead of M-x eval-last-sexp\r
+\r
+(C-j in lisp-interaction buffer, instead of c-x c-e)\r
+\r
+... I agree that if we handle the situation, perhaps throwing an\r
+error is not the best way...\r
+\r
+> [If anyone cares the current error comes from the marking read code in\r
+> the post-command hook which assumes the buffer has a message]\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>> ---\r
+>>  emacs/notmuch-show.el | 8 +++++++-\r
+>>  1 file changed, 7 insertions(+), 1 deletion(-)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index 3345878..335992e 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1248,7 +1248,13 @@ function is used."\r
+>>     (when (and (eq (buffer-size) 0)\r
+>>                notmuch-show-query-context)\r
+>>       (notmuch-show-insert-forest\r
+>> -      (notmuch-query-get-threads (append cli-args basic-args)))))\r
+>> +      (notmuch-query-get-threads (append cli-args basic-args))))\r
+>> +\r
+>> +   ;; If there are still no results, kill the buffer and throw an\r
+>> +   ;; error.\r
+>> +   (when (eq (buffer-size) 0)\r
+>> +     (kill-buffer (current-buffer))\r
+>> +     (error "No messages matched the query.")))\r
+>>  \r
+>>        (jit-lock-register #'notmuch-show-buttonise-links)\r
+>>  \r
+>> -- \r
+>> 2.1.4\r