--- /dev/null
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id C9873431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:19:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id hh+mDI91KjE8 for <notmuch@notmuchmail.org>;\r
+ Mon, 26 Nov 2012 09:19:34 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by olra.theworths.org (Postfix) with ESMTP id B4E48431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 26 Nov 2012 09:19:33 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 4D6421000E5;\r
+ Mon, 26 Nov 2012 19:19:30 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>,\r
+ Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 0/6] API for iterating over all messages in a thread\r
+In-Reply-To: <20121125212059.GN4562@mit.edu>\r
+References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>\r
+ <87ehjhkb3a.fsf@qmul.ac.uk> <20121125212059.GN4562@mit.edu>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 26 Nov 2012 19:19:30 +0200\r
+Message-ID: <m2624sffj1.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 26 Nov 2012 17:19:34 -0000\r
+\r
+On Sun, Nov 25 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> Quoth Mark Walters on Nov 25 at 2:31 pm:\r
+>> \r
+>> Hi\r
+>> \r
+>> This series looks good to me (I have not reviewed the two bindings\r
+>> patches). Patch 2 looks like it makes things much easier to follow than\r
+>> the current code (if I understood the current pointer stuff it\r
+>> constructs the top-level list by doing pointer stuff to remove all\r
+>> messages which are replies from the complete message list). Indeed, the\r
+>> diff is more complicated than the new code!\r
+>> \r
+>> On Sun, 25 Nov 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> > This series adds a library API for iterating over all messages in a\r
+>> > thread in sorted order. This is easy for the library to provide and\r
+>> > difficult to obtain from the current API. Plus, if you don't count\r
+>> > the code added to the bindings, this series is actually a net\r
+>> > decrease of 4 lines of code because of simplifications it enables.\r
+>> >\r
+>> > Do we want the API to do more? Currently it's very minimal, but I can\r
+>> > imagine two ways it could be generalized. It could take an argument\r
+>> > to indicate which message list to return, which could be all messages,\r
+>> > matched messages, top-level messages, or maybe even unmatched messages\r
+>> > (possibly all in terms of message flags). It could also take an\r
+>> > argument indicating the desired sort order. Currently, the caller can\r
+>> > use existing message flag APIs to distinguish matched and unmatched\r
+>> > messages and there's a separate function for the top-level messages.\r
+>> > However, if the API could do all of these things, it would subsume\r
+>> > various other API functions, such as notmuch_thread_get_*_date.\r
+>> \r
+>> I don't know if this is the right API. For the matched message etc I\r
+>> think using the existing message flag APIs is simple enough. I am not\r
+>> sure about sort orders though: that looks like it would be much easier\r
+>> for the caller to have the correct sort by I am not sure what users\r
+>> would need it.\r
+>\r
+> For sort order, I would be inclined to simply construct the reverse\r
+> list the first time a caller asks for it. Theoretically the caller\r
+> could do this just as easily as the library, except that we don't\r
+> expose the list routines.\r
+>\r
+> If I do add sort order, I would also want to add some control over\r
+> which list is returned, since it would be asymmetric to be able to\r
+> request all messages in either order, but top-level messages only in\r
+> oldest-first. I think this would be pretty simple, and would give us\r
+> a reasonably general-purpose and extensible API. (It would also solve\r
+> the naming conundrum I mentioned below in my original email.)\r
+\r
+The code looks good to me. \r
+\r
+I'm interested to see the extensible interface for returning desired\r
+list in desired sort order :)\r
+\r
+Tomi\r
+\r
+>\r
+>> Best wishes\r
+>> \r
+>> Mark\r
+>> \r
+>> \r
+>> >\r
+>> > Also, is this the right name for the new API? In particular, if we do\r
+>> > later want to add a function that returns, say, the list of matched\r
+>> > messages, we'll have a convention collision with\r
+>> > notmuch_thread_get_matched_messages, which returns only a count.\r
projects / notmuch-archives.git / commitdiff