Re: [PATCH 0/4] Allow specifying alternate names for addresses in other_email

diff --git a/40/cafcd95b9df733c2a5d9737380c3ad5ac15d34 b/40/cafcd95b9df733c2a5d9737380c3ad5ac15d34
new file mode 100644 (file)
index 0000000..7529e88
--- /dev/null
+++ b/40/cafcd95b9df733c2a5d9737380c3ad5ac15d34
@@ -0,0 +1,102 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 3AE836DE0A73\r
+ for <notmuch@notmuchmail.org>; Thu, 18 Aug 2016 03:53:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.007\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id KojutkY6O4rY for <notmuch@notmuchmail.org>;\r
+ Thu, 18 Aug 2016 03:53:05 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 638AD6DE0A6F\r
+ for <notmuch@notmuchmail.org>; Thu, 18 Aug 2016 03:53:05 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1baKwi-0007F4-VY; Thu, 18 Aug 2016 06:53:12 -0400\r
+Received: (nullmailer pid 7350 invoked by uid 1000);\r
+ Thu, 18 Aug 2016 10:52:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, Shea Levy <shea@shealevy.com>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4] Allow specifying alternate names for addresses in\r
+ other_email\r
+In-Reply-To: <874m6no4mm.fsf@nikula.org>\r
+References: <1470776118-5070-1-git-send-email-shea@shealevy.com>\r
+ <87k2fk98yh.fsf@nikula.org>\r
+ <87oa4vtta4.fsf@shlevy-laptop.i-did-not-set--mail-host-address--so-tickle-me>\r
+ <874m6no4mm.fsf@nikula.org>\r
+User-Agent: Notmuch/0.22.1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 18 Aug 2016 07:52:58 -0300\r
+Message-ID: <87oa4qqrg5.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.22\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 18 Aug 2016 10:53:06 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> Then there's the annoying detail that this'll change the format of the\r
+> config from a semicolon separated list to a comma separated list. This\r
+> means switching from using g_key_file_get_string_list() to\r
+> g_key_file_get_string(). But we also need to have backward compatibility\r
+> somehow. One option is to add a new config option (didn't I just frown\r
+> on adding new ones?) that would replace all of user.name,\r
+> user.primary_email, and user.other_email, making the first in the list\r
+> the primary one. So we could check if, say, user.email is present, and\r
+> use that for all of the name/primary/other configuration, falling back\r
+> to the separate fields otherwise.\r
+\r
+I guess if you wanted to be very friendly, you could support "virtual\r
+keys" for notmuch config so that "notmuch config get user.email" still\r
+works. Maybe that's already what you intend to suggest there. We already\r
+have config keys that are not stored in .notmuch-config\r
+\r
+I do agree that have two parallel arrays that the user is supposed to\r
+keep in sync is a classic bad interface design (we basically introduce\r
+structs/OOP by saying that's bad ;)). Other than that I'm open to what\r
+the config options look like, since setting them up is a rare operation.\r
+\r
+I think the only places in notmuch these config options are used is in\r
+notmuch-reply, and in the emacs client.\r
+\r
+It occurs to me that another option is some kind of versioning of config\r
+files, and yet another upgrade process (since we rewrite the whole\r
+config file anyway). This might be even more tedious to write, but at\r
+least the logic of dealing with different config file versions would all\r
+be in one place.\r
+\r
+> This is also a safe option in case some other software uses the\r
+> configuration options directly.\r
+\r
+I guess there's no safe option if people read the file directly, but I\r
+keep telling people not to do that ;). \r
+\r
+> Anyway, this will be slightly tedious to code, and some of the changes\r
+> might be a bit controversial, so I suggest waiting until we get feedback\r
+> from others first. (David, I'm looking at you!)\r
+\r
+not sure if these are the droids^Wfeedbacks you are looking for.\r
+\r
+d\r
+\r
+\r
+\r