Re: [RFC2 Patch 5/5] lib: iterator API for message properties

diff --git a/d3/0b5d7e5d826e1997343f77e869c2cd19f54cd3 b/d3/0b5d7e5d826e1997343f77e869c2cd19f54cd3
new file mode 100644 (file)
index 0000000..b2c3da6
--- /dev/null
+++ b/d3/0b5d7e5d826e1997343f77e869c2cd19f54cd3
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 606276DE02AD\r
+ for <notmuch@notmuchmail.org>; Tue, 31 May 2016 21:38:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.579\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.579 tagged_above=-999 required=5 tests=[AWL=-0.073,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id CbC9LpVYeSwq for <notmuch@notmuchmail.org>;\r
+ Tue, 31 May 2016 21:38:38 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 188956DE02A9\r
+ for <notmuch@notmuchmail.org>; Tue, 31 May 2016 21:38:37 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 1B9D410008E;\r
+ Wed,  1 Jun 2016 07:38:18 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC2 Patch 5/5] lib: iterator API for message properties\r
+In-Reply-To: <8760tthfuy.fsf@zancas.localnet>\r
+References: <1463927339-5441-1-git-send-email-david@tethera.net>\r
+ <1464608999-14774-1-git-send-email-david@tethera.net>\r
+ <1464608999-14774-6-git-send-email-david@tethera.net>\r
+ <8760tthfuy.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 01 Jun 2016 07:38:17 +0300\r
+Message-ID: <m2r3chcyme.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Jun 2016 04:38:46 -0000\r
+\r
+On Wed, Jun 01 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> +   notmuch_message_properties_t *list;\r
+>> +   RUN(notmuch_message_add_property (message, "testkey1", "bob"));\r
+>> +   RUN(notmuch_message_add_property (message, "testkey1", "testvalue2"));\r
+>> +   RUN(notmuch_message_add_property (message, "testkey1", "alice"));\r
+>> +\r
+>> +   for (list = notmuch_message_get_properties (message, "testkey1", TRUE);\r
+>> +        notmuch_message_properties_valid (list); notmuch_message_properties_move_to_next (list)) {\r
+>> +      printf("%s\n", notmuch_message_properties_value(list));\r
+>> +   }\r
+>> +   notmuch_message_properties_destroy (list);\r
+>\r
+> I was thinking a bit about how to dump/restore these.\r
+>\r
+> The most upwardly compatible way that i thought of is something like\r
+>\r
+> #= msg-id key=val key=val\r
+>\r
+> i.e. duplicate the msg-id for messages with properties\r
+>\r
+> This would be ignored by old notmuch-restore.\r
+>\r
+> Otherwise, maybe something like\r
+>\r
+> msg-id -- +tag +tag # key=val key=val\r
+>\r
+> I'm not sure. this might crash old notmuch-restore.\r
+>\r
+> How important is backward compatibility, and how important is minimizing\r
+> dump size? It's a bit hard to predict the things people might use\r
+> message properties for, but for thread surgery, I would expect a small\r
+> number of messages with properties.\r
+\r
+If we had compatibility version information in the dump file we could just\r
+bump the version. (and if we added to newer, old notmuches would not\r
+magically get that feature ;/)\r
+\r
+Anyay, IMO we could make backward-incompatible changes, and then perhaps\r
+provide conversion program (a few lines of perl(1) anyway (more lines on\r
+many other))\r
+\r
+Tomi\r
+\r
+>\r
+> d\r