Re: [PATCH v3] Make buttons for attachments allow viewing as well as saving

diff --git a/ea/6162ad3038cbdd1cbdace97af53aeb1d1f98ed b/ea/6162ad3038cbdd1cbdace97af53aeb1d1f98ed
new file mode 100644 (file)
index 0000000..fd1f4af
--- /dev/null
+++ b/ea/6162ad3038cbdd1cbdace97af53aeb1d1f98ed
@@ -0,0 +1,111 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C68D7431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 02:45:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Nl9vSNoeW8rD for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jan 2012 02:45:18 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3AA8F431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 02:45:18 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RnT0y-0006Cj-Qw; Wed, 18 Jan 2012 10:45:13 +0000\r
+Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]\r
+       helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1RnT0y-0004yY-Dj; Wed, 18 Jan 2012 10:45:12 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v3] Make buttons for attachments allow viewing as well as\r
+       saving\r
+In-Reply-To: <20120118012539.GA16740@mit.edu>\r
+References: <87lip5rj43.fsf@qmul.ac.uk>\r
+       <1326843886-18387-1-git-send-email-markwalters1009@gmail.com>\r
+       <20120117235318.GZ16740@mit.edu> <87ipk9rgg9.fsf@qmul.ac.uk>\r
+       <20120118012539.GA16740@mit.edu>\r
+User-Agent: Notmuch/0.11~rc2+73~g1ea2b60 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 18 Jan 2012 10:46:00 +0000\r
+Message-ID: <87fwfdqoev.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.192.233.223\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 8a7afb20fe3d809200e60c21cbfad16b (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.8 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay\r
+       *      domain\r
+       *  0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jan 2012 10:45:18 -0000\r
+\r
+\r
+> > +(defun notmuch-show-view-part (message-id nth &optional filename content-type )\r
+> > +  (notmuch-with-temp-part-buffer message-id nth\r
+> > +    ;; set mm-inlined-types to nil to force an external viewer\r
+> > +    (let ((handle (mm-make-handle (current-buffer) (list content-type)))\r
+> > +         (mm-inlined-types nil))\r
+> > +      ;; We override mm-save-part as notmuch-show-save-part is better\r
+> > +      ;; since it offers the filename\r
+> > +      (flet ((mm-save-part (&rest args) (ignore)))\r
+> > +           (or (mm-display-part handle)\r
+> > +               (notmuch-show-save-part message-id nth filename content-type))))))\r
+> > \r
+> > Is that a reasonable solution? \r
+> \r
+> It's *probably* safe to depend on the result of mm-display-part, but\r
+> you can avoid the question altogether by simply calling\r
+> notmuch-show-save-part from your flet mm-save-part.  E.g.,\r
+> \r
+> (flet ((mm-save-part (&rest args) (notmuch-show-save-part \r
+>                                    message-id nth filename content-type)))\r
+>   (mm-display-part handle))\r
+\r
+Unfortunately that does not work since mm-display-part has a local\r
+variable "filename".  I could copy the variables to some notmuch\r
+prefixed variables but maybe there is some obvious "quoting" to avoid\r
+the problem? (I can't easily check now as the gnu site is closed for the\r
+day.)\r
+\r
+Best wishes\r
+\r
+Mark\r