2004-10-22 Marcus Brinkmann <marcus@g10code.de>

	* engine-gpgsm.c (map_assuan_error): Return 0 if ERR is 0.
	(start): Call map_assuan_error on return value of
	assuan_write_line.

diff --git a/gpgme/ChangeLog b/gpgme/ChangeLog
index 7d6c5af65f03c15b5d62bb3742016d20b9bc1e08..9baaf6eab0c431a2334f841dd010695bbc2095bc 100644 (file)
--- a/gpgme/ChangeLog
+++ b/gpgme/ChangeLog
@@ -1,3 +1,9 @@
+2004-10-22  Marcus Brinkmann  <marcus@g10code.de>
+
+       * engine-gpgsm.c (map_assuan_error): Return 0 if ERR is 0.
+       (start): Call map_assuan_error on return value of
+       assuan_write_line.
+
 2004-10-05  Marcus Brinkmann  <marcus@g10code.de>
 
        * op-support.c (_gpgme_op_data_lookup): Use char pointer for

diff --git a/gpgme/engine-gpgsm.c b/gpgme/engine-gpgsm.c
index e08c03c74121ca4e9a98a950d57e0a25914d3726..0138fdf779879a9269d7c5b96ff265e16f76d5c3 100644 (file)
--- a/gpgme/engine-gpgsm.c
+++ b/gpgme/engine-gpgsm.c
@@ -153,6 +153,9 @@ close_notify_handler (int fd, void *opaque)
 static gpgme_error_t
 map_assuan_error (AssuanError err)
 {
+  if (!err)
+    return 0;
+
   if (err == -1)
     return gpg_error (GPG_ERR_INV_ENGINE);
 
@@ -398,6 +401,7 @@ gpgsm_new (void **engine, const char *lc_ctype, const char *lc_messages)
 
   err = assuan_pipe_connect (&gpgsm->assuan_ctx,
                             _gpgme_get_gpgsm_path (), argv, child_fds);
+  /* FIXME: Check error.  */
 
   /* We need to know the fd used by assuan for reads.  We do this by
      using the assumption that the first returned fd from
@@ -866,7 +870,7 @@ start (engine_gpgsm_t gpgsm, const char *command)
     err = add_io_cb (gpgsm, &gpgsm->message_cb, _gpgme_data_outbound_handler);
 
   if (!err)
-    err = assuan_write_line (gpgsm->assuan_ctx, command);
+    err = map_assuan_error (assuan_write_line (gpgsm->assuan_ctx, command));
 
   if (!err)
     (*gpgsm->io_cbs.event) (gpgsm->io_cbs.event_priv, GPGME_EVENT_START, NULL);