Re: [PATCH 1/4 v2] test: `visible-buffer-substring' should not return text properties.

diff --git a/bf/bd51fa76202b94fa5f4e51d8d4279ba98fcf78 b/bf/bd51fa76202b94fa5f4e51d8d4279ba98fcf78
new file mode 100644 (file)
index 0000000..aca2a36
--- /dev/null
+++ b/bf/bd51fa76202b94fa5f4e51d8d4279ba98fcf78
@@ -0,0 +1,107 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CE864429E36\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ocI8VM-rXCIo for <notmuch@notmuchmail.org>;\r
+       Wed, 25 Jan 2012 09:36:16 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1796D431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:15 -0800 (PST)\r
+Received: by bkbzt19 with SMTP id zt19so3689599bkb.26\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Jan 2012 09:36:14 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=XFwv70bRXYJtL1J/zrFgVY6Qkd8iRCRCE1l2n3rHZ70=;\r
+       b=QTy5LOMnp3YeCI3i1AmsiuC+qNOwYj5oF8FuLXabOMJt6ZIlR8AuxHiGqJoEJvQinO\r
+       210f1YluqBqjVkcqLwZcgBroDCn3fVLC2xKZQMhZWxApWj9//4QigrYwRMaugifeZ5Zn\r
+       nyfFWBITvzjmGR6S8kuEh5dnBk/NktV3AIeuU=\r
+Received: by 10.205.124.11 with SMTP id gm11mr7347922bkc.68.1327512974740;\r
+       Wed, 25 Jan 2012 09:36:14 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id bw9sm2496198bkb.8.2012.01.25.09.36.13\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 25 Jan 2012 09:36:14 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/4 v2] test: `visible-buffer-substring' should not return\r
+       text properties.\r
+In-Reply-To: <1327506328-22126-2-git-send-email-dme@dme.org>\r
+References: <1327503908-17226-1-git-send-email-dme@dme.org>\r
+       <1327506328-22126-1-git-send-email-dme@dme.org>\r
+       <1327506328-22126-2-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 25 Jan 2012 21:35:07 +0400\r
+Message-ID: <87sjj3heic.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 25 Jan 2012 17:36:16 -0000\r
+\r
+On Wed, 25 Jan 2012 15:45:25 +0000, David Edmondson <dme@dme.org> wrote:\r
+> When using `visible-buffer-substring' to examine a buffer, the text\r
+> properties are not useful, so don't include them.\r
+> ---\r
+>  test/test-lib.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+> \r
+> diff --git a/test/test-lib.el b/test/test-lib.el\r
+> index bc75f06..36e793a 100644\r
+> --- a/test/test-lib.el\r
+> +++ b/test/test-lib.el\r
+> @@ -60,7 +60,7 @@ FILENAME is OUTPUT."\r
+>      (while (< start end)\r
+>        (let ((next-pos (next-char-property-change start end)))\r
+>      (when (not (invisible-p start))\r
+> -      (setq str (concat str (buffer-substring start next-pos))))\r
+> +      (setq str (concat str (buffer-substring-no-properties start next-pos))))\r
+\r
+I would wrap this line.  But would not insist :)\r
+\r
+Please update `visible-buffer-substring' and `visible-buffer-string'\r
+docstring accordingly.  Smth like:\r
+\r
+  "Same as `buffer-substring-no-properties', but excludes invisible\r
+  text."\r
+\r
+  "Same as `buffer-string', but excludes invisible text and text\r
+  properties."\r
+\r
+Regards,\r
+  Dmitry\r
+\r
+>      (setq start next-pos)))\r
+>      str))\r
+>  \r
+> -- \r
+> 1.7.8.3\r
+> \r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r