Re: [PATCH] test: initial tests for smime

diff --git a/6a/b983c6b5f7a0036a96c1ad0720db3c10d6c81c b/6a/b983c6b5f7a0036a96c1ad0720db3c10d6c81c
new file mode 100644 (file)
index 0000000..bec8c7a
--- /dev/null
+++ b/6a/b983c6b5f7a0036a96c1ad0720db3c10d6c81c
@@ -0,0 +1,88 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16DD7431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 17 Jan 2015 14:29:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id j+60FvmVBXvh for <notmuch@notmuchmail.org>;\r
+       Sat, 17 Jan 2015 14:29:17 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DE731431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 17 Jan 2015 14:29:17 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1YCbrp-0002n3-2d; Sat, 17 Jan 2015 18:29:17 -0400\r
+Received: (nullmailer pid 26281 invoked by uid 1000); Sat, 17 Jan 2015\r
+       22:29:11 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>, Notmuch Mail\r
+       <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] test: initial tests for smime\r
+In-Reply-To: <87twzpt6e8.fsf@servo.finestructure.net>\r
+References: <87wq4ltbma.fsf@servo.finestructure.net>\r
+       <1421530691-14060-1-git-send-email-david@tethera.net>\r
+       <87twzpt6e8.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.19+27~g29ffde4 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 17 Jan 2015 23:29:11 +0100\r
+Message-ID: <87sif99h3c.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 17 Jan 2015 22:29:21 -0000\r
+\r
+Jameson Graef Rollins <jrollins@finestructure.net> writes:\r
+\r
+> For some reason PATCH 3/4 no longer applies after substituting in this\r
+> patch as PATCH 1/4.\r
+\r
+Ah, I guess I need to send the whole series again.\r
+\r
+>\r
+> But do we really need to test the message output of openssl?  It seems\r
+> like it's broken, and if it ever gets fixed we'll need to change this\r
+> test.\r
+\r
+I think it's not so much broken as "canonical". There is some discussion\r
+in the openssl-smime man page that pointed me to RFC5751\r
+para 3.1.1\r
+\r
+   MIME entities of major type "text" MUST have both their line endings\r
+   and character set canonicalized.  The line ending MUST be the pair of\r
+   characters <CR><LF>\r
+\r
+> But all we really care about is that openssl is properly verifying the\r
+> message, yes?  Why not just test that and forget about the rest of\r
+> openssl's output?\r
+\r
+Maybe it doesn't add too much as long as the message is using the "clear\r
+signed" multipart/signed format. On the other hand there is an opaque\r
+signed format (application/pkcs7-mime with Signeddata) too, where it\r
+would be interesting to check for mangling of the text. Similarly, when\r
+we add a similar test for encryption, I think we do want to check the\r
+content, so we'll have to figure this out at some point.\r
+\r
+Cheers,\r
+\r
+d\r