[PATCH v4 06/11] lib: Add the exclude flag to notmuch_query_search_threads
authorMark Walters <markwalters1009@gmail.com>
Thu, 2 Feb 2012 17:43:34 +0000 (17:43 +0000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:43:57 +0000 (09:43 -0800)
f1/a8d9a010bf179193a90fd5bf429fcd8b92cac7 [new file with mode: 0644]

diff --git a/f1/a8d9a010bf179193a90fd5bf429fcd8b92cac7 b/f1/a8d9a010bf179193a90fd5bf429fcd8b92cac7
new file mode 100644 (file)
index 0000000..a90dded
--- /dev/null
@@ -0,0 +1,178 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3CCB1429E36\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 09:43:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QhXMmpuqQ-19 for <notmuch@notmuchmail.org>;\r
+       Thu,  2 Feb 2012 09:43:08 -0800 (PST)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6F821431FBD\r
+       for <notmuch@notmuchmail.org>; Thu,  2 Feb 2012 09:43:07 -0800 (PST)\r
+Received: by mail-we0-f181.google.com with SMTP id b10so2324200wer.26\r
+       for <notmuch@notmuchmail.org>; Thu, 02 Feb 2012 09:43:07 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
+       bh=eAUX78p88IX+cG4hVJxkEo2EBDwpTAL60rWPZ7/6HBQ=;\r
+       b=mmTSMU4Bp0T0IO812Ul4GzEwjPS2z+2PmMTXUQk/0pSRDljR/xDIwqTU//ufqXFMgv\r
+       na6ijTX2froXmJ9ZDgW9rhScSxzflsl1CJACpiG2UPamwse4AaMAf1tprENKURZG8d4b\r
+       DHK+RYu1vkTPhmKI+4LVLu0ek0/aVJvwaxsCw=\r
+Received: by 10.216.138.102 with SMTP id z80mr4277872wei.38.1328204587111;\r
+       Thu, 02 Feb 2012 09:43:07 -0800 (PST)\r
+Received: from localhost (94-192-233-223.zone6.bethere.co.uk.\r
+ [94.192.233.223])     by mx.google.com with ESMTPS id\r
+ hc10sm1119723wib.8.2012.02.02.09.43.05        (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Thu, 02 Feb 2012 09:43:06 -0800 (PST)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org,\r
+       amdragon@MIT.EDU\r
+Subject: [PATCH v4 06/11] lib: Add the exclude flag to\r
+       notmuch_query_search_threads\r
+Date: Thu,  2 Feb 2012 17:43:34 +0000\r
+Message-Id: <1328204619-25046-6-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.2.3\r
+In-Reply-To: <874nv9rv79.fsf@qmul.ac.uk>\r
+References: <874nv9rv79.fsf@qmul.ac.uk>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 Feb 2012 17:43:10 -0000\r
+\r
+Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to\r
+notmuch_query_search_threads. Implemented by inspecting the tags\r
+directly in _notmuch_thread_create/_thread_add_message rather than as\r
+a Xapian query for speed reasons.\r
+---\r
+ lib/notmuch-private.h |    7 +++++--\r
+ lib/query.cc          |    1 +\r
+ lib/thread.cc         |   18 +++++++++++++++---\r
+ 3 files changed, 21 insertions(+), 5 deletions(-)\r
+\r
+diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h\r
+index e791bb0..ea836f7 100644\r
+--- a/lib/notmuch-private.h\r
++++ b/lib/notmuch-private.h\r
+@@ -148,6 +148,8 @@ typedef enum _notmuch_private_status {\r
\r
+ typedef struct _notmuch_doc_id_set notmuch_doc_id_set_t;\r
\r
++typedef struct _notmuch_string_list notmuch_string_list_t;\r
++\r
+ /* database.cc */\r
\r
+ /* Lookup a prefix value by name.\r
+@@ -216,6 +218,7 @@ _notmuch_thread_create (void *ctx,\r
+                       notmuch_database_t *notmuch,\r
+                       unsigned int seed_doc_id,\r
+                       notmuch_doc_id_set_t *match_set,\r
++                      notmuch_string_list_t *excluded_terms,\r
+                       notmuch_sort_t sort);\r
\r
+ /* message.cc */\r
+@@ -459,11 +462,11 @@ typedef struct _notmuch_string_node {\r
+     struct _notmuch_string_node *next;\r
+ } notmuch_string_node_t;\r
\r
+-typedef struct visible _notmuch_string_list {\r
++struct visible _notmuch_string_list {\r
+     int length;\r
+     notmuch_string_node_t *head;\r
+     notmuch_string_node_t **tail;\r
+-} notmuch_string_list_t;\r
++};\r
\r
+ notmuch_string_list_t *\r
+ _notmuch_string_list_create (const void *ctx);\r
+diff --git a/lib/query.cc b/lib/query.cc\r
+index 90a71a1..e1c3977 100644\r
+--- a/lib/query.cc\r
++++ b/lib/query.cc\r
+@@ -472,6 +472,7 @@ notmuch_threads_get (notmuch_threads_t *threads)\r
+                                  threads->query->notmuch,\r
+                                  doc_id,\r
+                                  &threads->match_set,\r
++                                 threads->query->exclude_terms,\r
+                                  threads->query->sort);\r
+ }\r
\r
+diff --git a/lib/thread.cc b/lib/thread.cc\r
+index 0435ee6..e976d64 100644\r
+--- a/lib/thread.cc\r
++++ b/lib/thread.cc\r
+@@ -214,7 +214,8 @@ _thread_cleanup_author (notmuch_thread_t *thread,\r
+  */\r
+ static void\r
+ _thread_add_message (notmuch_thread_t *thread,\r
+-                   notmuch_message_t *message)\r
++                   notmuch_message_t *message,\r
++                   notmuch_string_list_t *exclude_terms)\r
+ {\r
+     notmuch_tags_t *tags;\r
+     const char *tag;\r
+@@ -262,6 +263,15 @@ _thread_add_message (notmuch_thread_t *thread,\r
+        notmuch_tags_move_to_next (tags))\r
+     {\r
+       tag = notmuch_tags_get (tags);\r
++      /* Mark excluded messages. */\r
++      for (notmuch_string_node_t *term = exclude_terms->head; term;\r
++           term = term->next) {\r
++          /* We ignore initial 'K'. */\r
++          if (strcmp(tag, (term->string + 1)) == 0) {\r
++              notmuch_message_set_flag (message, NOTMUCH_MESSAGE_FLAG_EXCLUDED, TRUE);\r
++              break;\r
++          }\r
++      }\r
+       g_hash_table_insert (thread->tags, xstrdup (tag), NULL);\r
+     }\r
+ }\r
+@@ -321,7 +331,8 @@ _thread_add_matched_message (notmuch_thread_t *thread,\r
+           _thread_set_subject_from_message (thread, message);\r
+     }\r
\r
+-    thread->matched_messages++;\r
++    if (!notmuch_message_get_flag (message, NOTMUCH_MESSAGE_FLAG_EXCLUDED))\r
++      thread->matched_messages++;\r
\r
+     if (g_hash_table_lookup_extended (thread->message_hash,\r
+                           notmuch_message_get_message_id (message), NULL,\r
+@@ -392,6 +403,7 @@ _notmuch_thread_create (void *ctx,\r
+                       notmuch_database_t *notmuch,\r
+                       unsigned int seed_doc_id,\r
+                       notmuch_doc_id_set_t *match_set,\r
++                      notmuch_string_list_t *exclude_terms,\r
+                       notmuch_sort_t sort)\r
+ {\r
+     notmuch_thread_t *thread;\r
+@@ -467,7 +479,7 @@ _notmuch_thread_create (void *ctx,\r
+       if (doc_id == seed_doc_id)\r
+           message = seed_message;\r
\r
+-      _thread_add_message (thread, message);\r
++      _thread_add_message (thread, message, exclude_terms);\r
\r
+       if ( _notmuch_doc_id_set_contains (match_set, doc_id)) {\r
+           _notmuch_doc_id_set_remove (match_set, doc_id);\r
+-- \r
+1.7.2.3\r
+\r