Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during reply by default.

diff --git a/03/bb69c5202141479456dcc8aa81e809f982c8df b/03/bb69c5202141479456dcc8aa81e809f982c8df
new file mode 100644 (file)
index 0000000..87c15d4
--- /dev/null
+++ b/03/bb69c5202141479456dcc8aa81e809f982c8df
@@ -0,0 +1,93 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E4FFE6DE181C\r
+ for <notmuch@notmuchmail.org>; Wed, 16 Mar 2016 01:54:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.63\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.63 tagged_above=-999 required=5 tests=[AWL=-0.022, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Du4VEVyGVOFq for <notmuch@notmuchmail.org>;\r
+ Wed, 16 Mar 2016 01:54:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id DF2ED6DE181A\r
+ for <notmuch@notmuchmail.org>; Wed, 16 Mar 2016 01:54:24 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 03D69100063;\r
+ Wed, 16 Mar 2016 10:54:28 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during\r
+ reply by default.\r
+In-Reply-To: <1458117593-32586-1-git-send-email-dme@dme.org>\r
+References: <1458117593-32586-1-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.21+86~gd34ae6a (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 16 Mar 2016 10:54:27 +0200\r
+Message-ID: <m2a8lyajlo.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 16 Mar 2016 08:54:28 -0000\r
+\r
+On Wed, Mar 16 2016, David Edmondson <dme@dme.org> wrote:\r
+\r
+> [ text/plain ]\r
+> Based on feedback from users, change the default value of\r
+> `notmuch-mua-reply-insert-header-p-function' to\r
+> `notmuch-show-reply-insert-header-p-never', with the consequence that\r
+> replies will not have part header pseudo-buttons. This more closely\r
+> matches the behaviour before the recent changes to the reply code.\r
+> ---\r
+>  emacs/notmuch-mua.el | 2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index fcb3e95..773a000 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -94,7 +94,7 @@ Note that these functions use `mail-citation-hook' if that is non-nil."\r
+>    :group 'notmuch-reply)\r
+>  \r
+>  (defcustom notmuch-mua-reply-insert-header-p-function\r
+> -  'notmuch-show-reply-insert-header-p-trimmed\r
+> +  'notmuch-show-reply-insert-header-p-never\r
+>    "Function to decide which parts get a header when replying.\r
+\r
+LGTM. \r
+\r
+For test robustness, the related change in output of \r
+git show d27d90875dfb1 (<dme@dme.org>, Sat Feb 20 2016):\r
+\r
++;; For historical reasonse we don't print part headers when replying\r
++;; in the tests suite\r
++(setq notmuch-mua-reply-insert-header-p-function\r
+'notmuch-show-reply-insert-header-p-never)\r
+\r
+could also be reverted.\r
+\r
+(another thing that would be so cool: \r
+    #'notmuch-show-reply-insert-header-p-never\r
+but perhaps such a thing is to be done in separate patch "globally")\r
+\r
+\r
+Tomi\r