Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

diff --git a/d4/93e5465466c278d509e16757ab1c65a7c991ed b/d4/93e5465466c278d509e16757ab1c65a7c991ed
new file mode 100644 (file)
index 0000000..aa9af2b
--- /dev/null
+++ b/d4/93e5465466c278d509e16757ab1c65a7c991ed
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1C524431FC2\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 04:30:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2Z4MaOXyC9d9 for <notmuch@notmuchmail.org>;\r
+       Mon, 12 May 2014 04:30:51 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 92B5F431FC0\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 04:30:51 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1WjoQI-0007LJ-Bt; Mon, 12 May 2014 11:29:34 +0000\r
+Received: (nullmailer pid 3745 invoked by uid 1000); Mon, 12 May 2014\r
+       11:29:09 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h\r
+       with an underscore.\r
+In-Reply-To: <87d2fjgtcr.fsf@maritornes.cs.unb.ca>\r
+References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <87d2fjgtcr.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 12 May 2014 20:29:09 +0900\r
+Message-ID: <877g5rgrqy.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 11:30:59 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+>\r
+>> An underscore should precede every function name in\r
+>> lib/notmuch-private.h. This was not true and was noted by the failure of\r
+>> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore\r
+>> before each function name in lib/notmuch-private.h where the underscore\r
+>> was missing and renames functions appropriately where they are used.\r
+>\r
+> Originally I thought this was uneccesarily intrusive, but on a second\r
+> look I see that there is only one symbol changed that doesn't start with\r
+> _notmuch, so I guess for consistency it's fine.\r
+>\r
+> I'm thinking about a 0.18.1 point release for build and portability\r
+> fixes; I do think this is a bit too much change for that (especially\r
+> since it doesn't actually fix the symbol hiding test (or more precisely,\r
+> your fix for OS/X breaks the linux test).\r
+\r
+Also, I'd like a less confusing commit message.  Do you understand the\r
+situation enough to write one now? In particular it's just a convention\r
+that private symbols should not start with "notmuch", and the actual\r
+hiding happens elsewhere.\r
+\r
+d\r