Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

diff --git a/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5 b/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5
new file mode 100644 (file)
index 0000000..7997029
--- /dev/null
+++ b/06/b57b18d7d30218f2b55a3689b13afc7e93f1e5
@@ -0,0 +1,113 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5F457431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Feb 2012 00:56:43 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id UZJ9uOT1HV9K for <notmuch@notmuchmail.org>;\r
+       Mon,  6 Feb 2012 00:56:42 -0800 (PST)\r
+Received: from mail-we0-f181.google.com (mail-we0-f181.google.com\r
+       [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A2FF0431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Feb 2012 00:56:42 -0800 (PST)\r
+Received: by werb10 with SMTP id b10so4948789wer.26\r
+       for <notmuch@notmuchmail.org>; Mon, 06 Feb 2012 00:56:41 -0800 (PST)\r
+Received: by 10.216.139.97 with SMTP id b75mr2912119wej.0.1328518601272;\r
+       Mon, 06 Feb 2012 00:56:41 -0800 (PST)\r
+Received: from hotblack-desiato.hh.sledj.net\r
+       (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])\r
+       by mx.google.com with ESMTPS id l8sm44445312wiy.5.2012.02.06.00.56.39\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Mon, 06 Feb 2012 00:56:40 -0800 (PST)\r
+Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)\r
+       id 0DC9FA0484; Mon,  6 Feb 2012 08:56:38 +0000 (GMT)\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.\r
+In-Reply-To: <87obtcbd29.fsf@servo.finestructure.net>\r
+References: <1327496913-4946-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-1-git-send-email-dme@dme.org>\r
+       <1327918561-16245-3-git-send-email-dme@dme.org>\r
+       <87sjiobfu1.fsf@servo.finestructure.net>\r
+       <cunvcnk4d45.fsf@hotblack-desiato.hh.sledj.net>\r
+       <87obtcbd29.fsf@servo.finestructure.net>\r
+User-Agent: Notmuch/0.11.1+152~g2c6710e (http://notmuchmail.org)\r
+       Emacs/24.0.92.1 (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 06 Feb 2012 08:56:34 +0000\r
+Message-ID: <cunsjio49x9.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Gm-Message-State:\r
+ ALoCoQmUODSIOcRwU6QLgwS2KCpqkvJAu+KOPaCwNdOmTeBpTr5S9K2CyVh6OyVn1vAp0DGNQqap\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Feb 2012 08:56:43 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Mon, 06 Feb 2012 00:06:54 -0800, Jameson Graef Rollins <jrollins@finestr=\r
+ucture.net> wrote:\r
+> On Mon, 06 Feb 2012 07:47:38 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > On Sun, 05 Feb 2012 23:07:02 -0800, Jameson Graef Rollins <jrollins@fin=\r
+estructure.net> wrote:\r
+> > > Sorry to be so late on this, but I'm not a big fan of this new featur=\r
+e.\r
+> > > I would prefer to always see the subject (or any other field for that\r
+> > > matter) as is.\r
+> >=20\r
+> > The Emacs UI always replaced blank subjects with '[No Subject]' in\r
+> > buffer names. The printing code also needed something other than a blank\r
+> > subject for buffer renaming.\r
+>=20\r
+> I don't much care what the buffer name is.  That seems to be a\r
+> completely different issue to me.\r
+\r
+I agree that they could be treated differently.\r
+\r
+With blank subjects the printing code generated an error (because\r
+`rename-buffer' doesn't like an empty string as the first argument), so\r
+_some_ change is required.\r
+\r
+> > Updating `notmuch-prettify-subject' to use a user configurable string\r
+> > (that can be set to the empty string) sounds like a good idea. Please\r
+> > ensure that the various other bits of code that require something other\r
+> > than a blank subject still work properly.\r
+>=20\r
+> I am actually perfectly happy to see this patch reverted.\r
+\r
+Whatever bremner decides.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk8vlcIACgkQaezQq/BJZRaQWACfcu5lV+2cVdj4/Hw1LYIivFI7\r
+vA4AnArmPyqisnMeCSMLEb+o2HfRedKk\r
+=vWXE\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r