2010-04-19 Marcus Brinkmann <marcus@g10code.de>

	* assuan-support.c (my_spawn): Cast to avoid warning.
	* engine-g13.c (g13_new): Make ARGV array of pointer to const
	char.
	(g13_assuan_simple_command) [!USE_DESCRIPTOR_FUNCTION]: Don't define.
	* ops.h (_gpgme_key_append_name): Same in prototype.
	* key.c (_gpgme_key_append_name): Make SRC argument pointer to
	const char.
	* posix-util.c (_gpgme_get_uiserver_socket_path): Make HOMEDIR
	const.
	* vfs-mount.c (gpgme_op_vfs_transact_start): Never define this
	potentially useful but currently unused function.
	* vfs-create.c (gpgme_op_vfs_transact_start): Likewise.

diff --git a/src/ChangeLog b/src/ChangeLog
index d4ef220d56f44f04fcd74c8c98e3b17842b919c8..839ef6fd0663eaad693013eb0f858f30d43f8797 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,18 @@
+2010-04-19  Marcus Brinkmann  <marcus@g10code.de>
+
+       * assuan-support.c (my_spawn): Cast to avoid warning.
+       * engine-g13.c (g13_new): Make ARGV array of pointer to const
+       char.
+       (g13_assuan_simple_command) [!USE_DESCRIPTOR_FUNCTION]: Don't define.
+       * ops.h (_gpgme_key_append_name): Same in prototype.
+       * key.c (_gpgme_key_append_name): Make SRC argument pointer to
+       const char.
+       * posix-util.c (_gpgme_get_uiserver_socket_path): Make HOMEDIR
+       const.
+       * vfs-mount.c (gpgme_op_vfs_transact_start): Never define this
+       potentially useful but currently unused function.
+       * vfs-create.c (gpgme_op_vfs_transact_start): Likewise.
+
 2010-04-16  Werner Koch  <wk@g10code.com>
 
        * w32-io.c (is_socket): New.

diff --git a/src/assuan-support.c b/src/assuan-support.c
index c4d390ceeda6858f33b1b6282b421a3724a105ef..7b2a725dedfed7d3fbc1fcc3e74e91f3059c1491 100644 (file)
--- a/src/assuan-support.c
+++ b/src/assuan-support.c
@@ -158,8 +158,8 @@ my_spawn (assuan_context_t ctx, pid_t *r_pid, const char *name,
   fd_items[i].fd = -1;
   fd_items[i].dup_to = -1;
 
-  err = _gpgme_io_spawn (name, argv, IOSPAWN_FLAG_NOCLOSE, fd_items,
-                        atfork, atforkvalue, r_pid);
+  err = _gpgme_io_spawn (name, (char*const*)argv, IOSPAWN_FLAG_NOCLOSE,
+                        fd_items, atfork, atforkvalue, r_pid);
   if (! err)
     {
       i = 0;

diff --git a/src/engine-g13.c b/src/engine-g13.c
index 7ccca92c492e5800f87049ca0f4a0a312cce089b..07cfe7fa495d154be7f14aa2e15c50c8de65ad5a 100644 (file)
--- a/src/engine-g13.c
+++ b/src/engine-g13.c
@@ -211,7 +211,7 @@ g13_new (void **engine, const char *file_name, const char *home_dir)
   gpgme_error_t err = 0;
   engine_g13_t g13;
   int argc;
-  char *argv[5];
+  const char *argv[5];
   char *dft_display = NULL;
   char dft_ttyname[64];
   char *dft_ttytype = NULL;
@@ -392,6 +392,7 @@ g13_set_locale (void *engine, int category, const char *value)
 }
 
 
+#if USE_DESCRIPTOR_PASSING
 static gpgme_error_t
 g13_assuan_simple_command (assuan_context_t ctx, char *cmd,
                           engine_status_handler_t status_fnc,
@@ -442,6 +443,7 @@ g13_assuan_simple_command (assuan_context_t ctx, char *cmd,
 
   return err;
 }
+#endif
 
 
 static gpgme_error_t

diff --git a/src/key.c b/src/key.c
index 7dd38c5b84c0cfbff5df758ebc59b41b2066e7f4..37db81dea340f7f32e712e636c70f4a8cbd348fd 100644 (file)
--- a/src/key.c
+++ b/src/key.c
@@ -202,7 +202,7 @@ parse_x509_user_id (char *src, char **name, char **email,
 /* Take a name from the --with-colon listing, remove certain escape
    sequences sequences and put it into the list of UIDs.  */
 gpgme_error_t
-_gpgme_key_append_name (gpgme_key_t key, char *src, int convert)
+_gpgme_key_append_name (gpgme_key_t key, const char *src, int convert)
 {
   gpgme_user_id_t uid;
   char *dst;

diff --git a/src/ops.h b/src/ops.h
index 46c28eefdd320212a575e2af60276136d2a6009d..7b3025bb35038b0630e390e04851e32031d25c8e 100644 (file)
--- a/src/ops.h
+++ b/src/ops.h
@@ -128,7 +128,7 @@ gpgme_error_t _gpgme_progress_status_handler (void *priv,
 gpgme_error_t _gpgme_key_new (gpgme_key_t *r_key);
 gpgme_error_t _gpgme_key_add_subkey (gpgme_key_t key,
                                     gpgme_subkey_t *r_subkey);
-gpgme_error_t _gpgme_key_append_name (gpgme_key_t key, char *src, int convert);
+gpgme_error_t _gpgme_key_append_name (gpgme_key_t key, const char *src, int convert);
 gpgme_key_sig_t _gpgme_key_add_sig (gpgme_key_t key, char *src);
 
 \f

diff --git a/src/posix-util.c b/src/posix-util.c
index 3acc7e086c573e19e4ef58c8292f550fd9342411..d7ed8f093016f3eee91a6267ff14dab06a23cade 100644 (file)
--- a/src/posix-util.c
+++ b/src/posix-util.c
@@ -74,7 +74,7 @@ const char *
 _gpgme_get_uiserver_socket_path (void)
 {
   static char *socket_path;
-  char *homedir;
+  const char *homedir;
   const char name[] = "S.uiserver";
 
   if (socket_path)

diff --git a/src/vfs-create.c b/src/vfs-create.c
index 9a65e0c098900ecf044c4be517fc881af13af4c8..142549a1eb8f7251e2d8f222c9011df1f1b6ccca 100644 (file)
--- a/src/vfs-create.c
+++ b/src/vfs-create.c
@@ -58,7 +58,7 @@ vfs_start (gpgme_ctx_t ctx, int synchronous,
 }
 
 
-
+#if 0
 /* XXXX.  This is the asynchronous variant. */
 static gpgme_error_t
 gpgme_op_vfs_transact_start (gpgme_ctx_t ctx, 
@@ -73,6 +73,7 @@ gpgme_op_vfs_transact_start (gpgme_ctx_t ctx,
   return vfs_start (ctx, 0, command, data_cb, data_cb_value,
                    inq_cb, inq_cb_value, status_cb, status_cb_value);
 }
+#endif
 
 
 /* XXXX.  This is the synchronous variant. */

diff --git a/src/vfs-mount.c b/src/vfs-mount.c
index f5a6286c17400a8546dde63239496eea6a15d59d..b913689567c208c41541376d35296e5fdbebf9b9 100644 (file)
--- a/src/vfs-mount.c
+++ b/src/vfs-mount.c
@@ -116,6 +116,7 @@ vfs_start (gpgme_ctx_t ctx, int synchronous,
 
 
 
+#if 0
 /* XXXX.  This is the asynchronous variant. */
 static gpgme_error_t
 gpgme_op_vfs_transact_start (gpgme_ctx_t ctx, 
@@ -130,6 +131,7 @@ gpgme_op_vfs_transact_start (gpgme_ctx_t ctx,
   return vfs_start (ctx, 0, command, data_cb, data_cb_value,
                    inq_cb, inq_cb_value, status_cb, status_cb_value);
 }
+#endif
 
 
 /* XXXX.  This is the synchronous variant. */