Re: [PATCH 1/2] test: add check for <expected> filename argument for test_expect_equa...

diff --git a/1e/1ffa17c610886b341529847611efd0fd9ff41b b/1e/1ffa17c610886b341529847611efd0fd9ff41b
new file mode 100644 (file)
index 0000000..97cd0ba
--- /dev/null
+++ b/1e/1ffa17c610886b341529847611efd0fd9ff41b
@@ -0,0 +1,94 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 989C8431FBD\r
+       for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 03:05:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 99jr2Ssm7y2I for <notmuch@notmuchmail.org>;\r
+       Thu, 18 Oct 2012 03:05:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1D3EE431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 18 Oct 2012 03:05:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 130B31000E5;\r
+       Thu, 18 Oct 2012 13:05:43 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for\r
+       test_expect_equal_file\r
+In-Reply-To: <87vcefa8ov.fsf@betacantrips.com>\r
+References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87zkd1p12c.fsf@servo.finestructure.net>\r
+       <87sjishv3e.fsf@gmail.com> <87vcefa8ov.fsf@betacantrips.com>\r
+User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 18 Oct 2012 13:05:43 +0300\r
+Message-ID: <m28vb4jds8.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 18 Oct 2012 10:05:40 -0000\r
+\r
+On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:\r
+\r
+> Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:\r
+>\r
+>> Actually, we can do both: check file name for consistent diff order\r
+>> (from expected to actual) and use file names that the caller provides.\r
+>\r
+> Hi! Reviewing the patch queue a little bit here. It seems like this\r
+> patch ended up getting dropped because the other approach (using the\r
+> filenames that the caller provided) won out and was even pushed. I'm\r
+> therefore marking this series notmuch::obsolete (and also\r
+> notmuch::stale since it doesn't apply cleanly).\r
+\r
+I think stale is unnecessary and inconvenient when patch is marked\r
+obsolete\r
+\r
+1) it is easier to look for stale patches by just searching stale tag\r
+2) most obsolete patch goes stale at later time\r
+\r
+If no-one resists I'll execute\r
+\r
+notmuch tag -notmuch::stale tag:notmuch::obsolete\r
+\r
+in near future (I take silence as an approval :D).\r
+\r
+Currently:\r
+\r
+notmuch search --output=messages tag:notmuch::stale and tag:notmuch::obsolete\r
+\r
+id:1334077496-9172-3-git-send-email-markwalters1009@gmail.com\r
+id:1334077496-9172-2-git-send-email-markwalters1009@gmail.com\r
+id:1331402091-15663-1-git-send-email-tom.prince@ualberta.net\r
+id:1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com\r
+id:1327985666-29191-3-git-send-email-dmitry.kurochkin@gmail.com\r
+id:1327961195-4204-2-git-send-email-dmitry.kurochkin@gmail.com\r
+id:1327926286-16680-2-git-send-email-dmitry.kurochkin@gmail.com\r
+id:1325986015-22510-5-git-send-email-jrollins@finestructure.net\r
+\r
+\r
+Tomi\r