Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly creat...

diff --git a/2a/8aaa1183d0e76f43d6a25a1c276d0ed6dba0ef b/2a/8aaa1183d0e76f43d6a25a1c276d0ed6dba0ef
new file mode 100644 (file)
index 0000000..cf83745
--- /dev/null
+++ b/2a/8aaa1183d0e76f43d6a25a1c276d0ed6dba0ef
@@ -0,0 +1,96 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39A4A431FBD;\r
+       Fri,  4 Dec 2009 16:12:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id oifTl9k2mbxV; Fri,  4 Dec 2009 16:12:48 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 436BF431FAE;\r
+       Fri,  4 Dec 2009 16:12:48 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id EE2122542FB; Fri,  4 Dec 2009 16:12:47 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>,\r
+ notmuch@notmuchmail.org\r
+In-Reply-To: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>\r
+References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>\r
+Date: Fri, 04 Dec 2009 16:12:47 -0800\r
+Message-ID: <87ocmee0sg.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Subject: Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix=\r
+ and properly create Makefile.config\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Dec 2009 00:12:49 -0000\r
+\r
+--=-=-=\r
+\r
+On Sat, 28 Nov 2009 18:57:35 -0500, Jameson Graef Rollins <jrollins@finestructure.net> wrote:\r
+> This also removes the Makefile.config from the repository, since it\r
+> shouldn't be kept in the repository and should be created by the\r
+> configure script.\r
+\r
+Hi Jamie,\r
+\r
+Handling --prefix will be a nice addition to our configure script. So,\r
+thanks!\r
+\r
+Your commit message has that flag word of "also" in it, and as it turns\r
+out, the removal of Makefile.config from the repository has actually\r
+happened already. But that was easy enough to fix.\r
+\r
+> +# option parsing\r
+> +for option; do\r
+> +    if [ "${option%=*}" = '--prefix' ] ; then\r
+> +    PREFIX="${option#*=}"\r
+> +    fi\r
+> +done\r
+\r
+I've gone ahead and committed that now. Then I noticed that we should\r
+really use ${option%%=*} to support the case of an option value\r
+containing an '=' character. So I fixed that.\r
+\r
+Then, since I was in the area, I added support to configure for\r
+capturing CFLAGS from the environment, I fixed this (and also "make\r
+CFLAGS=") to also influence C++ compilation (still can be separately\r
+overridden with CXXFLAGS), and I fixed our quiet-compilation mode to\r
+actually print the (user-specified) CFLAGS.\r
+\r
+Finally, I documented things by adding a "configure --help" to document\r
+CC, CFLAGS, and --prefix; and by making "make" tell the user about\r
+"./configure" and "./configure --help" when make runs configure\r
+implicitly.\r
+\r
+Our configuration system certainly isn't as full-featured yet as a\r
+standard autoconf-based configure script, but I'm quite happy with how\r
+clean it is for both users and developers.\r
+\r
+-Carl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLGaV/6JDdNq8qSWgRAoTsAKCa8LqALafG9tGjAGTP4HQat8YHEwCffMjd\r
+qwhQlBNHuaC+vk1iNwhe/jM=\r
+=gFfw\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r