Re: [PATCH 2/5] configure, test: Added variables for paths to true and false.

diff --git a/2d/61219be77a97144beff247e298244d74fc5091 b/2d/61219be77a97144beff247e298244d74fc5091
new file mode 100644 (file)
index 0000000..13b9346
--- /dev/null
+++ b/2d/61219be77a97144beff247e298244d74fc5091
@@ -0,0 +1,78 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4A9E2431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 15:15:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id tS7dwS9Dl8mL for <notmuch@notmuchmail.org>;\r
+       Thu,  8 May 2014 15:15:52 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E9D2F431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  8 May 2014 15:15:51 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1WiWaJ-0000OH-7m; Thu, 08 May 2014 22:14:35 +0000\r
+Received: (nullmailer pid 12559 invoked by uid 1000); Thu, 08 May 2014\r
+       22:14:15 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/5] configure,    test: Added variables for paths to true\r
+       and false.\r
+In-Reply-To: <m238gkpb7s.fsf@jane.lan>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu>\r
+       <87fvkkv4bc.fsf@maritornes.cs.unb.ca> <m238gkpb7s.fsf@jane.lan>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 09 May 2014 07:14:15 +0900\r
+Message-ID: <877g5vvryg.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 08 May 2014 22:15:59 -0000\r
+\r
+Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+\r
+> I will be the first too admit that I do not know much about configure\r
+> scripts, but adding a TRUE variable seemed straightforward. \r
+\r
+configure is already big enough, I'd prefer not to add new things unless\r
+they are needed.  This is not likely to be something the user wants to\r
+change, and (as you note below) it's pretty easy for the the Makefile or\r
+tests to guess.\r
+\r
+>  You could use `$(which true)` in test/Makefile.local, but I felt the\r
+> code repetition there was unecessary since you could just create a\r
+> TRUE variable in the configure script.\r
+\r
+well, it's not really code repetition because it is only used in that\r
+one place.\r
+\r
+> An alternative is to change the tests so that the location of true\r
+> (and false) is no longer an issue.\r
+\r
+Sure, that would be fine too.\r
+\r
+d\r