Re: [PATCH v2 0/8] Improve tag change completion

diff --git a/52/c9ce653843d3aa4d4d7ee80e12b0616454cc8a b/52/c9ce653843d3aa4d4d7ee80e12b0616454cc8a
new file mode 100644 (file)
index 0000000..28d8daa
--- /dev/null
+++ b/52/c9ce653843d3aa4d4d7ee80e12b0616454cc8a
@@ -0,0 +1,127 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 203D4431FC7\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 11:28:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hsG3898Ahk5s for <notmuch@notmuchmail.org>;\r
+       Wed, 23 Oct 2013 11:28:35 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id ABB26431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 11:28:35 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E9976100217;\r
+       Wed, 23 Oct 2013 21:28:27 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/8] Improve tag change completion\r
+In-Reply-To: <87k3h40y64.fsf@qmul.ac.uk>\r
+References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
+       <87k3h40y64.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 23 Oct 2013 21:28:27 +0300\r
+Message-ID: <m2hac7u9is.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Oct 2013 18:28:45 -0000\r
+\r
+On Wed, Oct 23 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> In might of id:20131023154404.GE20337@mit.edu I am now happy with this\r
+> series. LGTM +1 \r
+\r
+Looks Good To Me, too - and worked in my test tagging operations as \r
+announced +1\r
+\r
+Tomi\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+> On Wed, 23 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+>> This is v2 of id:1382471457-26056-1-git-send-email-amdragon@mit.edu.\r
+>> It improves some documentation strings, fixes one bug, and elimintes\r
+>> some redundant code.  The diff from v1 is below.\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index ef77839..f66d669 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1800,7 +1800,6 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+>>     (list (let (tags)\r
+>>        (notmuch-show-mapc\r
+>>         (lambda () (setq tags (append (notmuch-show-get-tags) tags))))\r
+>> -      (delete-dups tags)\r
+>>        (notmuch-read-tag-changes tags "Tag thread"))))\r
+>>    (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+>>    (notmuch-show-mapc\r
+>> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+>> index feee17c..7b21006 100644\r
+>> --- a/emacs/notmuch-tag.el\r
+>> +++ b/emacs/notmuch-tag.el\r
+>> @@ -189,6 +189,9 @@ the messages that were tagged"\r
+>>  `notmuch-read-tag-changes' function.")\r
+>>  \r
+>>  (defun notmuch-tag-completions (&rest search-terms)\r
+>> +  "Return a list of tags for messages matching SEARCH-TERMS.\r
+>> +\r
+>> +Returns all tags if no search terms are given."\r
+>>    (if (null search-terms)\r
+>>        (setq search-terms (list "*")))\r
+>>    (split-string\r
+>> @@ -199,7 +202,7 @@ the messages that were tagged"\r
+>>     "\n+" t))\r
+>>  \r
+>>  (defun notmuch-select-tag-with-completion (prompt &rest search-terms)\r
+>> -  (let ((tag-list (notmuch-tag-completions search-terms)))\r
+>> +  (let ((tag-list (apply #'notmuch-tag-completions search-terms)))\r
+>>      (completing-read prompt tag-list nil nil nil 'notmuch-select-tag-history)))\r
+>>  \r
+>>  (defun notmuch-read-tag-changes (current-tags &optional prompt initial-input)\r
+>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+>> index 5492e1b..53e9826 100644\r
+>> --- a/emacs/notmuch.el\r
+>> +++ b/emacs/notmuch.el\r
+>> @@ -584,7 +584,10 @@ Returns (TAG-CHANGES REGION-BEGIN REGION-END)."\r
+>>    "Change tags for the currently selected thread or region.\r
+>>  \r
+>>  See `notmuch-tag' for information on the format of TAG-CHANGES.\r
+>> -If BEG or END are nil, applies to the thread at point."\r
+>> +When called interactively, this uses the region if the region is\r
+>> +active.  When called directly, BEG and END provide the region.\r
+>> +If these are nil or not provided, this applies to the thread at\r
+>> +point."\r
+>>    (interactive (notmuch-search-interactive-tag-changes))\r
+>>    (unless (and beg end) (setq beg (point) end (point)))\r
+>>    (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r