Re: [PATCH v3] emacs: add stash support for git send-email command line

diff --git a/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8 b/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8
new file mode 100644 (file)
index 0000000..752f57c
--- /dev/null
+++ b/a7/6772caafac0f306d41e30d5b9d37cb070ee5f8
@@ -0,0 +1,141 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 835AB431FAF\r
+       for <notmuch@notmuchmail.org>; Fri,  2 Jan 2015 11:54:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2IFXhp0-poob for <notmuch@notmuchmail.org>;\r
+       Fri,  2 Jan 2015 11:54:33 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 78CF5431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  2 Jan 2015 11:54:33 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 9630D100051;\r
+       Fri,  2 Jan 2015 21:54:04 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Edmondson <dme@dme.org>, Jani Nikula <jani@nikula.org>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3] emacs: add stash support for git send-email\r
+       command line\r
+In-Reply-To: <cunh9w9gigs.fsf@gargravarr.hh.sledj.net>\r
+References: <cuna921smnf.fsf@gargravarr.hh.sledj.net>\r
+       <1420220897-6245-1-git-send-email-jani@nikula.org>\r
+       <cunh9w9gigs.fsf@gargravarr.hh.sledj.net>\r
+User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 02 Jan 2015 21:54:04 +0200\r
+Message-ID: <m2387t2c2r.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 02 Jan 2015 19:54:37 -0000\r
+\r
+On Fri, Jan 02 2015, David Edmondson <dme@dme.org> wrote:\r
+\r
+> Looks good to me.\r
+\r
+\r
+LGTM, too, and seems to work -- and docstrings actually adhere the\r
+conventions...\r
+\r
+from http://web.mit.edu/Emacs/source/emacs/lisp/emacs-lisp/checkdoc.el\r
+\r
+     ;; * Format the documentation string so that it fits in an\r
+     ;;   Emacs window on an 80-column screen.  It is a good idea\r
+     ;;   for most lines to be no wider than 60 characters.  The\r
+     ;;   first line can be wider if necessary to fit the\r
+     ;;   information that ought to be there.\r
+\r
+Tomi\r
+\r
+> On Fri, Jan 02 2015, Jani Nikula wrote:\r
+>> Stash From/To/Cc as --to/--to/--cc, respectively, and Message-Id as\r
+>> --in-reply-to, suitable for pasting to git send-email command line.\r
+>> ---\r
+>>  emacs/notmuch-show.el | 38 ++++++++++++++++++++++++++++++++++++++\r
+>>  1 file changed, 38 insertions(+)\r
+>>\r
+>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+>> index b8cfbb8a3286..9f6fe077df0c 100644\r
+>> --- a/emacs/notmuch-show.el\r
+>> +++ b/emacs/notmuch-show.el\r
+>> @@ -1280,6 +1280,7 @@ reset based on the original query."\r
+>>      (define-key map "t" 'notmuch-show-stash-to)\r
+>>      (define-key map "l" 'notmuch-show-stash-mlarchive-link)\r
+>>      (define-key map "L" 'notmuch-show-stash-mlarchive-link-and-go)\r
+>> +    (define-key map "G" 'notmuch-show-stash-git-send-email)\r
+>>      (define-key map "?" 'notmuch-subkeymap-help)\r
+>>      map)\r
+>>    "Submap for stash commands")\r
+>> @@ -2131,6 +2132,43 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."\r
+>>    (notmuch-show-stash-mlarchive-link mla)\r
+>>    (browse-url (current-kill 0 t)))\r
+>>  \r
+>> +(defun notmuch-show-stash-git-helper (addresses prefix)\r
+>> +  "Escape, trim, quote, and add PREFIX to each address in list of ADDRESSES, and return the result as a single string."\r
+>> +  (mapconcat (lambda (x)\r
+>> +          (concat prefix "\""\r
+>> +                  ;; escape double-quotes\r
+>> +                  (replace-regexp-in-string\r
+>> +                   "\"" "\\\\\""\r
+>> +                   ;; trim leading and trailing spaces\r
+>> +                   (replace-regexp-in-string\r
+>> +                    "\\(^ *\\| *$\\)" ""\r
+>> +                    x)) "\""))\r
+>> +        addresses " "))\r
+>> +\r
+>> +(put 'notmuch-show-stash-git-send-email 'notmuch-prefix-doc\r
+>> +     "Copy From/To/Cc of current message to kill-ring in a form suitable for pasting to git send-email command line.")\r
+>> +\r
+>> +(defun notmuch-show-stash-git-send-email (&optional no-in-reply-to)\r
+>> +  "Copy From/To/Cc/Message-Id of current message to kill-ring in a form suitable for pasting to git send-email command line.\r
+>> +\r
+>> +If invoked with a prefix argument (or NO-IN-REPLY-TO is non-nil),\r
+>> +omit --in-reply-to=<Message-Id>."\r
+>> +  (interactive "P")\r
+>> +  (notmuch-common-do-stash\r
+>> +   (mapconcat 'identity\r
+>> +         (remove ""\r
+>> +                 (list\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-from)) "--to=")\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-to)) "--to=")\r
+>> +                  (notmuch-show-stash-git-helper\r
+>> +                   (message-tokenize-header (notmuch-show-get-cc)) "--cc=")\r
+>> +                  (unless no-in-reply-to\r
+>> +                    (notmuch-show-stash-git-helper\r
+>> +                     (list (notmuch-show-get-message-id t)) "--in-reply-to="))))\r
+>> +         " ")))\r
+>> +\r
+>>  ;; Interactive part functions and their helpers\r
+>>  \r
+>>  (defun notmuch-show-generate-part-buffer (message-id nth)\r
+>> -- \r
+>> 2.1.4\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r