Re: [PATCH] emacs: make sure tagging on an empty query is harmless
authorDavid Bremner <david@tethera.net>
Wed, 28 May 2014 12:57:13 +0000 (09:57 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:03:02 +0000 (10:03 -0800)
01/06b1683fd7922ada25a90b362be92a59935c6f [new file with mode: 0644]

diff --git a/01/06b1683fd7922ada25a90b362be92a59935c6f b/01/06b1683fd7922ada25a90b362be92a59935c6f
new file mode 100644 (file)
index 0000000..6c2f3da
--- /dev/null
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B435431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 28 May 2014 05:57:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Md4tLX3JR+4w for <notmuch@notmuchmail.org>;\r
+       Wed, 28 May 2014 05:57:21 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 7043E431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 28 May 2014 05:57:21 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WpdPx-0006F3-BY; Wed, 28 May 2014 09:57:17 -0300\r
+Received: (nullmailer pid 27602 invoked by uid 1000); Wed, 28 May 2014\r
+       12:57:13 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org, David\r
+       Edmondson <dme@dme.org>\r
+Subject: Re: [PATCH] emacs: make sure tagging on an empty query is harmless\r
+In-Reply-To: <1400666330-4363-1-git-send-email-markwalters1009@gmail.com>\r
+References: <87iop0ynl2.fsf@qmul.ac.uk>\r
+       <1400666330-4363-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 28 May 2014 09:57:13 -0300\r
+Message-ID: <878upm2h92.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 May 2014 12:57:25 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> Currently notmuch-tag throws a "wrong-type-argument stringp nil" if\r
+> passed a nil query-string. Catch this and provide a more useful error\r
+> message. This fixes a case in notmuch-tree (if you try to tag when at\r
+> the end of the buffer).\r
+\r
+pushed to release and master\r
+\r
+d\r