Re: [PATCH] go: add binding for notmuch_message_get_date
authorTrevor Jim <tjim@mac.com>
Tue, 3 Mar 2015 16:22:54 +0000 (11:22 +1900)
committerW. Trevor King <wking@tremily.us>
Sat, 20 Aug 2016 21:48:13 +0000 (14:48 -0700)
fb/182304456b657a9aa8cf5119e110e6c312ddb4 [new file with mode: 0644]

diff --git a/fb/182304456b657a9aa8cf5119e110e6c312ddb4 b/fb/182304456b657a9aa8cf5119e110e6c312ddb4
new file mode 100644 (file)
index 0000000..620ee46
--- /dev/null
@@ -0,0 +1,77 @@
+Return-Path: <tjim@mac.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 63EC5431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  3 Mar 2015 08:24:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.139\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.139 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TBUpavKBx7e6 for <notmuch@notmuchmail.org>;\r
+       Tue,  3 Mar 2015 08:24:53 -0800 (PST)\r
+Received: from nk11p00mm-asmtp002.mac.com (nk11p00mm-asmtp002.mac.com\r
+       [17.158.161.1])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 2FCB0431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  3 Mar 2015 08:24:53 -0800 (PST)\r
+Received: from localhost (aegis.CS.Princeton.EDU [128.112.139.195])\r
+       by nk11p00mm-asmtp002.mac.com\r
+       (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Dec 4\r
+       2014))\r
+       with ESMTPSA id <0NKN00FC69I7D300@nk11p00mm-asmtp002.mac.com> for\r
+       notmuch@notmuchmail.org; Tue, 03 Mar 2015 16:22:57 +0000 (GMT)\r
+X-Proofpoint-Virus-Version: vendor=fsecure\r
+       engine=2.50.10432:5.13.68,1.0.33,0.0.0000\r
+       definitions=2015-03-03_05:2015-03-03, 2015-03-03,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\r
+       adjust=0\r
+       reason=mlx scancount=1 engine=7.0.1-1412110000\r
+       definitions=main-1503030177\r
+From: Trevor Jim <tjim@mac.com>\r
+To: David Bremner <david@tethera.net>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] go: add binding for notmuch_message_get_date\r
+In-reply-to: <87385mmasu.fsf@maritornes.cs.unb.ca>\r
+References: <m2fv9np216.fsf@att.com> <m261aimfcm.fsf@guru.guru-group.fi>\r
+       <87385mmasu.fsf@maritornes.cs.unb.ca>\r
+Date: Tue, 03 Mar 2015 11:22:54 -0500\r
+Message-id: <m261aijbj5.fsf@att.com>\r
+MIME-version: 1.0\r
+Content-type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 03 Mar 2015 16:24:56 -0000\r
+\r
+> Given the current troubles with the main library API and missing status\r
+> values, I'd say in the long run we'll be happier with a real status\r
+> return. OTOH, I don't much about go.\r
+\r
+I'm not sure what the "current troubles" are (happy to hear more), but\r
+the way I've handled the nil case is in keeping with the way it's\r
+handled in the other function bindings for go.  Adding an error return\r
+to all relevant functions seems like a big change that should be handled\r
+separately, yes?\r
+\r
+In defense of the current strategy, any caller can check for the nil\r
+case before calling.\r
+\r
+-T\r