Re: [PATCH 2/9] Add a lazily-initialized crypto context to notmuch_database_t

diff --git a/98/1998e871f86be823407088365bfa965971fc40 b/98/1998e871f86be823407088365bfa965971fc40
new file mode 100644 (file)
index 0000000..03fe2b0
--- /dev/null
+++ b/98/1998e871f86be823407088365bfa965971fc40
@@ -0,0 +1,80 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 5EA326DE0A9A\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 06:36:46 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.017\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5\r
+ tests=[AWL=-0.017] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id lVevpNoNwfwj for <notmuch@notmuchmail.org>;\r
+ Fri, 11 Dec 2015 06:36:44 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 86DF46DE0B4B\r
+ for <notmuch@notmuchmail.org>; Fri, 11 Dec 2015 06:36:44 -0800 (PST)\r
+Received: from fifthhorseman.net (unknown [38.109.115.130])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id B004BF984;\r
+ Fri, 11 Dec 2015 09:36:42 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id B7E8F2006D; Fri, 11 Dec 2015 09:36:42 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/9] Add a lazily-initialized crypto context to\r
+ notmuch_database_t\r
+In-Reply-To: <871tatf5gm.fsf@zancas.localnet>\r
+References: <1449718786-28000-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1449718786-28000-3-git-send-email-dkg@fifthhorseman.net>\r
+ <871tatf5gm.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 11 Dec 2015 09:36:42 -0500\r
+Message-ID: <8737v9hx1h.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 11 Dec 2015 14:36:46 -0000\r
+\r
+On Fri 2015-12-11 09:03:05 -0500, David Bremner wrote:\r
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>\r
+>> This is in large part a duplicate of parts of crypto.c, but that code\r
+>> is in the client (outside the library), and we don't want to entangle\r
+>> the libgmime API with the libnotmuch API.\r
+>>\r
+>> I welcome better proposals for how to share this code explicitly\r
+>> between the library and the client.\r
+>\r
+> Maybe I miss something obvious, but util/libutil.a is exactly there for\r
+> sharing code between the library and the client.\r
+\r
+You didn't miss anything obvious -- i did!  Thanks for pointing that\r
+out, i'll take a look at normalizing these bits for my second draft.\r
+\r
+> perhaps something like "gmime-extra.c" to go with {talloc,zlib}-extra.c\r
+\r
+right, sounds good.\r
+\r
+> I didn't look at the code yet, just the commentary.\r
+\r
+many thanks for the review, that's why i wrote the commentary :)\r
+\r
+After a couple nights of sleep, i have a proposal to fix one of the\r
+open questions too, which i'll follow up on shortly here.\r
+\r
+     --dkg\r