Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces

diff --git a/60/a37b9a6e07cd79b56fd4f88a013e97d9279802 b/60/a37b9a6e07cd79b56fd4f88a013e97d9279802
new file mode 100644 (file)
index 0000000..d084585
--- /dev/null
+++ b/60/a37b9a6e07cd79b56fd4f88a013e97d9279802
@@ -0,0 +1,120 @@
+Return-Path: <amdragon@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 719DB431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Mar 2011 19:57:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.698\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
+       HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HAmEQrMfE9xo for <notmuch@notmuchmail.org>;\r
+       Sun, 27 Mar 2011 19:57:49 -0700 (PDT)\r
+Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com\r
+       [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9E6D1431FB5\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Mar 2011 19:57:49 -0700 (PDT)\r
+Received: by qwb7 with SMTP id 7so1491505qwb.26\r
+       for <notmuch@notmuchmail.org>; Sun, 27 Mar 2011 19:57:46 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=domainkey-signature:mime-version:sender:date:x-google-sender-auth\r
+       :message-id:subject:from:to:cc:content-type;\r
+       bh=trz0q/y3Pt8s5ghJgnEoe2iIBPxiWDRzJ3tipztJDZU=;\r
+       b=u63Bzg5xeGFzRM5C6VcLUlEQwv4D6pFUEM7ZdE1yS1zdcmecLmhNwDtvE6hRIsV3XD\r
+       jihzjb5TnY/fSb3u3RXc3ZBfsCqObbdavsdjt6bp+KOuHWmxYemHMt8ITXjPeOssegg1\r
+       WoU8RmXAWlk/PVTGbWwnD0g2gJJM4IyEww5OE=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
+       h=mime-version:sender:date:x-google-sender-auth:message-id:subject\r
+       :from:to:cc:content-type;\r
+       b=oyr14ZsifM78Ow1zuzMXsVC71SGRdbk072yZKjqBZJbEPnKz+B7RI23ie5w+rsl8s0\r
+       OIRWx108/9NoVnkO3WhwNbGCMT+6fI5N1aPuKl7gwEKiXGb/P6w5sAHOVDQpY8FnDngG\r
+       ZsPckb0o0LKCJwYa+VlpV5mRLjma1XvRzVPV0=\r
+MIME-Version: 1.0\r
+Received: by 10.229.130.168 with SMTP id t40mr2827290qcs.140.1301281066382;\r
+       Sun, 27 Mar 2011 19:57:46 -0700 (PDT)\r
+Sender: amdragon@gmail.com\r
+Received: by 10.229.30.68 with HTTP; Sun, 27 Mar 2011 19:57:46 -0700 (PDT)\r
+Received: by 10.229.30.68 with HTTP; Sun, 27 Mar 2011 19:57:46 -0700 (PDT)\r
+Date: Sun, 27 Mar 2011 22:57:46 -0400\r
+X-Google-Sender-Auth: cJ-qm_g9zLYg_nas2MCF0nF8G54\r
+Message-ID: <BANLkTimiR25ic=t0aEGnrn5bNBeuuzx+pA@mail.gmail.com>\r
+Subject: Re: [PATCH] use custom-face-edit value-type in\r
+       notmuch-search-line-faces\r
+From: Austin Clements <amdragon@mit.edu>\r
+To: Jameson Rollins <jrollins@finestructure.net>\r
+Content-Type: multipart/alternative; boundary=0015175925fab6f465049f821bcb\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 28 Mar 2011 02:57:50 -0000\r
+\r
+--0015175925fab6f465049f821bcb\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+\r
+On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins <jrollins@finestructure.net>\r
+wrote:\r
+> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <\r
+jrollins@finestructure.net> wrote:\r
+>> This enables the proper face customization UI for\r
+>> notmuch-search-line-faces.\r
+>\r
+> Hey, folks.  amdragon was the one who figured out that custom-face-edit\r
+> was the correct value-type to use to get the face customization ui for\r
+> the notmuch-search-line-faces list.  However, he seems to think this\r
+> might not be the right solution.  Austin: care to comment?\r
+\r
+My concern is that it's unclear if the custom-face-edit widget is considered\r
+a public interface, or if it's internal to customize and thus could change\r
+at any time. These things are always a bit murky in Emacs. custom-face-edit\r
+has been around for a few major versions, though it only recently (somewhere\r
+between Emacs 22 and 23) became embeddable in a customize widget like this.\r
+We should just ask on an Emacs mailing list if this is okay, or if it will\r
+break catastrophically and without warning at some point (or if there's a\r
+more official solution).\r
+\r
+--0015175925fab6f465049f821bcb\r
+Content-Type: text/html; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<p>On Sun, Mar 27, 2011 at 1:26 AM, Jameson Rollins &lt;<a href=3D"mailto:j=\r
+rollins@finestructure.net">jrollins@finestructure.net</a>&gt; wrote:<br>\r
+&gt; On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins &lt;<a href=\r
+=3D"mailto:jrollins@finestructure.net">jrollins@finestructure.net</a>&gt; w=\r
+rote:<br>\r
+&gt;&gt; This enables the proper face customization UI for<br>\r
+&gt;&gt; notmuch-search-line-faces.<br>\r
+&gt;<br>\r
+&gt; Hey, folks. =A0amdragon was the one who figured out that custom-face-e=\r
+dit<br>\r
+&gt; was the correct value-type to use to get the face customization ui for=\r
+<br>\r
+&gt; the notmuch-search-line-faces list. =A0However, he seems to think this=\r
+<br>\r
+&gt; might not be the right solution. =A0Austin: care to comment?</p>\r
+<p>My concern is that it&#39;s unclear if the custom-face-edit widget is co=\r
+nsidered a public interface, or if it&#39;s internal to customize and thus =\r
+could change at any time. These things are always a bit murky in Emacs. cus=\r
+tom-face-edit has been around for a few major versions, though it only rece=\r
+ntly (somewhere between Emacs 22 and 23) became embeddable in a customize w=\r
+idget like this. We should just ask on an Emacs mailing list if this is oka=\r
+y, or if it will break catastrophically and without warning at some point (=\r
+or if there&#39;s a more official solution).</p>\r
+\r
+\r
+--0015175925fab6f465049f821bcb--\r