Re: [PATCH] doc: forbid further operations on a closed database

diff --git a/de/73b39f6f487bf7e20001f3e52259c6bea3debb b/de/73b39f6f487bf7e20001f3e52259c6bea3debb
new file mode 100644 (file)
index 0000000..bb19007
--- /dev/null
+++ b/de/73b39f6f487bf7e20001f3e52259c6bea3debb
@@ -0,0 +1,74 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E735F6DE01BA\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 14:17:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.566\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.566 tagged_above=-999 required=5 tests=[AWL=-0.086,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id dZwu9rUxloT5 for <notmuch@notmuchmail.org>;\r
+ Mon, 27 Jun 2016 14:17:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A43846DE014D\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 14:17:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 5373E1000E1;\r
+ Tue, 28 Jun 2016 00:16:41 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, David Bremner <david@tethera.net>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] doc: forbid further operations on a closed database\r
+In-Reply-To: <1467052720-18041-1-git-send-email-david@tethera.net>\r
+References: <87porqxmm5.fsf@tesseract.cs.unb.ca>\r
+ <1467052720-18041-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 28 Jun 2016 00:16:41 +0300\r
+Message-ID: <m27fdawcw6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jun 2016 21:17:33 -0000\r
+\r
+On Mon, Jun 27 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> We could add many null pointer checks, but currently I don't see a use\r
+> case that justifies it.\r
+> ---\r
+>  lib/notmuch.h | 4 +++-\r
+>  1 file changed, 3 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/lib/notmuch.h b/lib/notmuch.h\r
+> index d4a97cb..2faa146 100644\r
+> --- a/lib/notmuch.h\r
+> +++ b/lib/notmuch.h\r
+> @@ -332,7 +332,9 @@ notmuch_database_status_string (const notmuch_database_t *notmuch);\r
+>   * functions on objects derived from this database may either behave\r
+>   * as if the database had not been closed (e.g., if the required data\r
+>   * has been cached) or may fail with a\r
+> - * NOTMUCH_STATUS_XAPIAN_EXCEPTION.\r
+> + * NOTMUCH_STATUS_XAPIAN_EXCEPTION. The only further operation\r
+> + * permitted on the database itself is to call\r
+> + * notmuch_database_destroy.\r
+\r
+LGTM\r