Re: Last minute fixes to the go bindings

diff --git a/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1 b/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1
new file mode 100644 (file)
index 0000000..df2337e
--- /dev/null
+++ b/d0/c2b57afc45c1a01e1dd77918a3c856c79dd0d1
@@ -0,0 +1,97 @@
+Return-Path: <teythoon@jade-hamburg.de>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C452E431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 10 May 2012 07:36:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nJn3QRKhoBDl for <notmuch@notmuchmail.org>;\r
+       Thu, 10 May 2012 07:36:55 -0700 (PDT)\r
+Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 77F0A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 10 May 2012 07:36:55 -0700 (PDT)\r
+Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])\r
+       (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by mail.cryptobitch.de (Postfix) with ESMTPSA id 651BC589EE1\r
+       for <notmuch@notmuchmail.org>; Thu, 10 May 2012 16:36:53 +0200 (CEST)\r
+Received: by mail.jade-hamburg.de (Postfix, from userid 401)\r
+       id D3B87DF2A3; Thu, 10 May 2012 16:36:52 +0200 (CEST)\r
+Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de\r
+ [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits))     (No client\r
+ certificate requested) (Authenticated sender: teythoon)       by\r
+ mail.jade-hamburg.de (Postfix) with ESMTPSA id 19990DF2A0;    Thu, 10 May 2012\r
+ 16:36:50 +0200 (CEST)\r
+Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)\r
+       (envelope-from <teythoon@thinkbox.jade-hamburg.de>)\r
+       id 1SSUU6-0006JR-9L; Thu, 10 May 2012 16:36:50 +0200\r
+Content-Type: text/plain; charset="utf-8"\r
+MIME-Version: 1.0\r
+Content-Transfer-Encoding: quoted-printable\r
+To: Austin Clements <amdragon@MIT.EDU>, \r
+From: Justus Winter <4winter@informatik.uni-hamburg.de>\r
+In-Reply-To: <20120509180700.GA11804@mit.edu>\r
+References:\r
+ <1336558988-6813-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <20120509180700.GA11804@mit.edu>\r
+Message-ID: <20120510143650.5975.92158@thinkbox.jade-hamburg.de>\r
+User-Agent: alot/0.3+\r
+Subject: Re: Last minute fixes to the go bindings\r
+Date: Thu, 10 May 2012 16:36:50 +0200\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 10 May 2012 14:36:57 -0000\r
+\r
+Quoting Austin Clements (2012-05-09 20:07:00)\r
+> LGTM.\r
+> =\r
+\r
+> Quoth Justus Winter on May 09 at 12:23 pm:\r
+> > Hi everyone :)\r
+> > =\r
+\r
+> > this is a small patch series that I'd like to see included in 0.13.\r
+> > =\r
+\r
+> > The first patch updates notmuch-addrlookup with respect to Austins\r
+> > recent change of the notmuch_database_open function. This fixes the\r
+> > compilation of the utility.\r
+> > =\r
+\r
+> > The second patch fixes the values of all the STATUS_* constants. Turns\r
+> > out all of them were set to zero by accident. This isn't a c style\r
+> > enum, golang has the iota operator to do this kind of stuff. This\r
+> > fixes the error handling for all the users of the go bindings.\r
+> =\r
+\r
+> 'Doh!  Is it possible to get the status values out of cgo, rather than\r
+> depending on the list in libnotmuch and the list in Go being in the\r
+> same order?\r
+\r
+Yes, it is and I've prepared a patch. But since I'm living in go 1\r
+land here I prepared it on top of my go 1 patchset and I'm thinking of\r
+sending it once that one got merged.\r
+\r
+@David: what do you think about merging this patch set?\r
+\r
+Justus\r