Re: [bug] notmuch requires Content-Disposition mime header value to be lower case

diff --git a/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551 b/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551
new file mode 100644 (file)
index 0000000..8a2509f
--- /dev/null
+++ b/e6/ccc271992b4a79e86e88d236d6adbdd2fc9551
@@ -0,0 +1,91 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E910F6DE01F7\r
+ for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:40 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.114\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id OV6ppnVJwvaF for <notmuch@notmuchmail.org>;\r
+ Fri, 18 Sep 2015 05:04:39 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id E95E96DE00DE\r
+ for <notmuch@notmuchmail.org>; Fri, 18 Sep 2015 05:04:38 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZcuOC-0001FU-V0; Fri, 18 Sep 2015 12:03:40 +0000\r
+Received: (nullmailer pid 9821 invoked by uid 1000); Fri, 18 Sep 2015\r
+ 12:03:20 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Johannes Schauer <josch@debian.org>, notmuch@notmuchmail.org\r
+Subject: Re: [bug] notmuch requires Content-Disposition mime header value to\r
+ be lower case\r
+In-Reply-To: <20150917083956.1941.35098@localhost>\r
+References: <20150917070056.1941.94846@localhost>\r
+ <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost>\r
+User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Fri, 18 Sep 2015 09:03:20 -0300\r
+Message-ID: <87pp1grl2v.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 18 Sep 2015 12:04:41 -0000\r
+\r
+Johannes Schauer <josch@debian.org> writes:\r
+\r
+\r
+> Funnily though there seem to be some weird newline differences that I cannot\r
+> explain, so I left them for somebody else to fix.\r
+>\r
+\r
+Looking at the files (.EXPECTED and .OUTPUT) in test/tmp.T190-multipart,\r
+there's more than whitespace changes. Some things that used to marked\r
+"attachment" in the output are now marked "part".\r
+\r
+> diff --git a/test/T190-multipart.sh b/test/T190-multipart.sh\r
+> index 7c4c9f7..f16cc90 100755\r
+> --- a/test/T190-multipart.sh\r
+> +++ b/test/T190-multipart.sh\r
+> @@ -48,7 +48,7 @@ cat embedded_message >> ${MAIL_DIR}/multipart\r
+>  cat <<EOF >> ${MAIL_DIR}/multipart\r
+>  \r
+>  --=-=-=\r
+> -Content-Disposition: attachment; filename=attachment\r
+> +Content-Disposition: ATTACHMENT; FILENAME=attachment\r
+>  \r
+>  This is a text attachment.\r
+>  \r
+> @@ -487,7 +487,7 @@ This is an embedded message, with a multipart/alternative part.\r
+>  --==-=-==--\r
+>  \r
+>  --=-=-=\r
+> -Content-Disposition: attachment; filename=attachment\r
+> +Content-Disposition: ATTACHMENT; FILENAME=attachment\r
+>  \r
+>  This is a text attachment.\r
+>  \r
+\r
+I'd recommend making your own new test, rather than modifying existing\r
+ones to test multiple things.  I'd also recommend using json / sexp\r
+output for your tests, since the ad-hoc text format is kindof\r
+semi-deprecated.\r
+\r
+d\r