Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom

diff --git a/d2/17a2ae16bcb3cafce44a900f94255ac36fc05c b/d2/17a2ae16bcb3cafce44a900f94255ac36fc05c
new file mode 100644 (file)
index 0000000..ce6a14c
--- /dev/null
+++ b/d2/17a2ae16bcb3cafce44a900f94255ac36fc05c
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2F05B431FBF\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Apr 2014 03:52:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id a7hOnsWxKWJX for <notmuch@notmuchmail.org>;\r
+       Wed, 16 Apr 2014 03:51:56 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6F50B431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Apr 2014 03:51:56 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1WaNRX-0006tt-Eb; Wed, 16 Apr 2014 07:51:51 -0300\r
+Received: (nullmailer pid 28687 invoked by uid 1000); Wed, 16 Apr 2014\r
+       10:51:47 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom\r
+In-Reply-To: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1397627927-9692-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.17+200~gd83a69b (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 16 Apr 2014 07:51:47 -0300\r
+Message-ID: <8738hdwnr0.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 16 Apr 2014 10:52:01 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> ---\r
+> Hi\r
+>\r
+> David found a bug in the recent notmuch hello saved searches and\r
+> reduced to a small test case. The problem occurs if the user sets\r
+> notmuch-saved-searches and then loads notmuch. The reason is that the\r
+> defcustom calls some utility functions and these need to be defined\r
+> (not just declared) when the defcustom is encountered.\r
+>\r
+> This patch moves the code around so that they are defined first. I\r
+> have marked the patch WIP as I am not sure what the best reordering\r
+> is, and we may want to rename some functions which have changed file\r
+> for namespace reasons.\r
+>\r
+> Anyway this fixes the test case. If it fixes the original bug too then\r
+> I will provide a better version.\r
+\r
+Hi Mark;\r
+\r
+This fixes the problem for me.\r
+\r
+Thanks for your efforts,\r
+\r
+d\r