--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 39899431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 7 Oct 2013 23:48:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id vq+E7rRkOnaw for <notmuch@notmuchmail.org>;\r
+ Mon, 7 Oct 2013 23:48:23 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id E07A8431FAE\r
+ for <notmuch@notmuchmail.org>; Mon, 7 Oct 2013 23:48:22 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VTR5d-00071M-Mk; Tue, 08 Oct 2013 07:48:20 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1VTR5d-0004wh-DH; Tue, 08 Oct 2013 07:48:17 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 02/11] cli: Separate current and deprecated format version\r
+In-Reply-To: <1381185201-25197-3-git-send-email-amdragon@mit.edu>\r
+References: <1381185201-25197-1-git-send-email-amdragon@mit.edu>\r
+ <1381185201-25197-3-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 08 Oct 2013 07:48:16 +0100\r
+Message-ID: <87li24qmvj.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: c2eda50662eedae62c3917f54ed92ea8 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Oct 2013 06:48:27 -0000\r
+\r
+On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Previously, the CLI would print a deprecation warning if a client\r
+> requested any format version other than the current one. However, if\r
+> we add fields that are backwards-compatible, but want clients to be\r
+> able to depend on, we need to bump the version, but that doesn't make\r
+> the older version deprecated.\r
+>\r
+> Hence, separate out the "minimum active" version and only print a\r
+> warning for requests below this version number.\r
+> ---\r
+> notmuch-client.h | 5 +++++\r
+> notmuch.c | 2 +-\r
+> 2 files changed, 6 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/notmuch-client.h b/notmuch-client.h\r
+> index afb0ddf..8d986f4 100644\r
+> --- a/notmuch-client.h\r
+> +++ b/notmuch-client.h\r
+> @@ -142,6 +142,11 @@ chomp_newline (char *str)\r
+> /* The minimum supported structured output format version. Requests\r
+> * for format versions below this will return an error. */\r
+> #define NOTMUCH_FORMAT_MIN 1\r
+> +/* The minimum non-deprecated structured output format version.\r
+> + * Requests for format versions below this will print a stern warning.\r
+> + * Must be >= NOTMUCH_FORMAT_MIN and < NOTMUCH_FORMAT_CUR.\r
+> + */\r
+\r
+Should this be <= NOTMUCH_FORMAT_CUR ?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> +#define NOTMUCH_FORMAT_MIN_ACTIVE 1\r
+> \r
+> /* The output format version requested by the caller on the command\r
+> * line. If no format version is requested, this will be set to\r
+> diff --git a/notmuch.c b/notmuch.c\r
+> index 7300c21..6588003 100644\r
+> --- a/notmuch.c\r
+> +++ b/notmuch.c\r
+> @@ -125,7 +125,7 @@ by the notmuch CLI (it requires at least version %d). You may need to\n\\r
+> upgrade your notmuch front-end.\n",\r
+> notmuch_format_version, NOTMUCH_FORMAT_MIN);\r
+> exit (NOTMUCH_EXIT_FORMAT_TOO_OLD);\r
+> - } else if (notmuch_format_version != NOTMUCH_FORMAT_CUR) {\r
+> + } else if (notmuch_format_version < NOTMUCH_FORMAT_MIN_ACTIVE) {\r
+> /* Warn about old version requests so compatibility issues are\r
+> * less likely when we drop support for a deprecated format\r
+> * versions. */\r
+> -- \r
+> 1.8.4.rc3\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff