Add a TODO note about remaining work for bug #189417.
authorZac Medico <zmedico@gentoo.org>
Fri, 7 Dec 2007 09:59:48 +0000 (09:59 -0000)
committerZac Medico <zmedico@gentoo.org>
Fri, 7 Dec 2007 09:59:48 +0000 (09:59 -0000)
svn path=/main/trunk/; revision=8864

pym/portage/__init__.py

index e5c73d1163cbe6ddfb6cc05c1ba081a703726a3b..545e33afa6e6d0ea0bbe48d977ca76f248c13ad7 100644 (file)
@@ -2583,6 +2583,11 @@ class config(object):
                        if filter_calling_env and \
                                x not in environ_whitelist and \
                                not self._environ_whitelist_re.match(x):
+                               # TODO: Complete the whitelist so that comparisons with
+                               # environment variables are not necessary. We want to
+                               # prevent all but whitelisted variables from being able
+                               # to leak into the environment, so a variable can be unset
+                               # and it will remain unset for all phases (bug #189417).
                                if myvalue == env_d.get(x) or \
                                        myvalue == os.environ.get(x):
                                        continue