Re: [PATCH v2 03/10] python: handle return status of database close and destroy

diff --git a/f5/a3e65bca75319308e62ddb0bc453dcde658892 b/f5/a3e65bca75319308e62ddb0bc453dcde658892
new file mode 100644 (file)
index 0000000..e56d71a
--- /dev/null
+++ b/f5/a3e65bca75319308e62ddb0bc453dcde658892
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5AA8E431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:46:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8bE8fmvFDMpt for <notmuch@notmuchmail.org>;\r
+       Sat,  5 Jul 2014 05:46:10 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C90A8431FAF\r
+       for <notmuch@notmuchmail.org>; Sat,  5 Jul 2014 05:46:10 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1X3PKD-0005oW-IA; Sat, 05 Jul 2014 12:44:17 +0000\r
+Received: (nullmailer pid 23741 invoked by uid 1000); Sat, 05 Jul 2014\r
+       12:43:58 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 03/10] python: handle return status of database close\r
+       and     destroy\r
+In-Reply-To: <1397653165-15620-4-git-send-email-novalazy@gmail.com>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+       <1397653165-15620-4-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.18.1+22~gbf82697 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 05 Jul 2014 09:43:58 -0300\r
+Message-ID: <87y4w8q8kx.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Jul 2014 12:46:16 -0000\r
+\r
+Peter Wang <novalazy@gmail.com> writes:\r
+\r
+> Throw an exception if notmuch_database_close or notmuch_database_destroy\r
+> fail.\r
+> ---\r
+>  bindings/python/notmuch/database.py | 12 ++++++++----\r
+>  1 file changed, 8 insertions(+), 4 deletions(-)\r
+>\r
+\r
+I don't really feel qualified to review changes to the python bindings.\r
+Justus, are you still following/mainting the python bindings? If so,\r
+what do you think of this patch?\r
+\r
+d\r