Re: notmuch-0.16: realpath() compatibility issue; clang visibility problem

diff --git a/02/ac8b6ba8ae71f9566490b971e6a78e0b6695cc b/02/ac8b6ba8ae71f9566490b971e6a78e0b6695cc
new file mode 100644 (file)
index 0000000..0e8358f
--- /dev/null
+++ b/02/ac8b6ba8ae71f9566490b971e6a78e0b6695cc
@@ -0,0 +1,88 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 12267431FC0\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:18:35 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bR2E+QpzxqlK for <notmuch@notmuchmail.org>;\r
+       Sat,  4 Jan 2014 05:18:27 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 08E13431FBD\r
+       for <notmuch@notmuchmail.org>; Sat,  4 Jan 2014 05:18:26 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VzR7L-0005H9-RW; Sat, 04 Jan 2014 09:18:19 -0400\r
+Received: (nullmailer pid 21265 invoked by uid 1000); Sat, 04 Jan 2014\r
+       13:18:15 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Thomas Klausner <tk@giga.or.at>, notmuch@notmuchmail.org\r
+Subject: Re: notmuch-0.16: realpath() compatibility issue; clang visibility\r
+       problem\r
+In-Reply-To: <20140103214735.GG27614@danbala.tuwien.ac.at>\r
+References: <20140103214735.GG27614@danbala.tuwien.ac.at>\r
+User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 04 Jan 2014 09:18:15 -0400\r
+Message-ID: <871u0nnaw8.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 Jan 2014 13:18:35 -0000\r
+\r
+Thomas Klausner <tk@giga.or.at> writes:\r
+\r
+>                                 ^\r
+> ./lib/notmuch-private.h:52:13: note: previous attribute is here\r
+> #pragma GCC visibility push(hidden)\r
+>             ^\r
+\r
+The clang related issues might be fixed in 0.17; can you try that (or\r
+git master)?\r
+\r
+>      size_t length;\r
+> -    char *data, *filename;\r
+> +    char *data, filename[MAXPATHLEN];\r
+>      GError *error = NULL;\r
+\r
+I'm not sure what the right answer is here. MATHPATHLEN (and PATH_MAX)\r
+are not necessarily defined; in particular this would break\r
+compilation on GNU Hurd. Perhaps we should ship a compatibility\r
+implementation of a POSIX.1-2008 compatible [1] realpath. Or maybe\r
+realpath can be avoided completely here.\r
+\r
+> +        strcpy(filename, config->filename);\r
+\r
+Any reason not to use strncpy here?\r
+\r
+Of course bug reports and fixes in any form are always welcome, but even\r
+more appreciated if they roughly follow [2]; mainly patches from git\r
+with sensible commit messages, and some minor coding style issues.\r
+\r
+cheers,\r
+\r
+d\r
+\r
+\r
+[1]: http://pubs.opengroup.org/onlinepubs/9699919799/ \r
+[2]: http://notmuchmail.org/contributing/\r