Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap

diff --git a/e0/365fd3233623c1225df3fd60cf4c9f78370b1a b/e0/365fd3233623c1225df3fd60cf4c9f78370b1a
new file mode 100644 (file)
index 0000000..1887116
--- /dev/null
+++ b/e0/365fd3233623c1225df3fd60cf4c9f78370b1a
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 72DE56DE1320\r
+ for <notmuch@notmuchmail.org>; Sat, 21 Nov 2015 03:51:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.092\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.092 tagged_above=-999 required=5 tests=[AWL=0.092]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id HVJ7Isjmt-qj for <notmuch@notmuchmail.org>;\r
+ Sat, 21 Nov 2015 03:51:54 -0800 (PST)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 4B72F6DE0A87\r
+ for <notmuch@notmuchmail.org>; Sat, 21 Nov 2015 03:51:53 -0800 (PST)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1a06gT-0003dK-FQ; Sat, 21 Nov 2015 11:50:25 +0000\r
+Received: (nullmailer pid 13560 invoked by uid 1000); Sat, 21 Nov 2015\r
+ 11:50:06 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: hello: fix accidental modification of\r
+ widget-keymap\r
+In-Reply-To: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 21 Nov 2015 07:50:06 -0400\r
+Message-ID: <87610v607l.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 21 Nov 2015 11:51:56 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> In emacs24 we use make-composed-keymap. It seems that if only a single\r
+> map is specified then emacs just resuses it rather than creating a\r
+> copy of it. Thus use make-sparse-keymap to force a copy.\r
+> ---\r
+>\r
+> pseudomyne and the diredful author thamer found that we modify\r
+> widget-keymap in notmuch. We clearly don't want to, and I think we\r
+> tried not to, but emacs was being clever and reused the old keymap\r
+> rather than creating a new one.\r
+\r
+I have tested this patch against the latest diredful.el and it seems to\r
+be OK. Barring protests I'll apply it against release, and start to\r
+build 0.21.1 ; not sure if we have any other suitable bug fixes to\r
+include.\r
+\r
+d\r