Re: ./configure with CC="ccache gcc" doesn't work

diff --git a/6f/22f3a9523d3b813a0b55f5196c8c336dee73a9 b/6f/22f3a9523d3b813a0b55f5196c8c336dee73a9
new file mode 100644 (file)
index 0000000..8326679
--- /dev/null
+++ b/6f/22f3a9523d3b813a0b55f5196c8c336dee73a9
@@ -0,0 +1,105 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 00ADE431FD0\r
+       for <notmuch@notmuchmail.org>; Wed, 26 Jan 2011 05:38:30 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.99\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.99 tagged_above=-999 required=5\r
+       tests=[ALL_TRUSTED=-1, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 1t2Q+a3cmfYr; Wed, 26 Jan 2011 05:38:30 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 150DB431FB5;\r
+       Wed, 26 Jan 2011 05:38:30 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 437322540DE; Wed, 26 Jan 2011 23:38:29 +1000 (EST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, Andy Wingo <wingo@oblong.com>\r
+Subject: Re: ./configure with CC="ccache gcc" doesn't work\r
+In-Reply-To: <87mxmv4p3k.fsf@steelpick.2x.cz>\r
+References: <m3ei8897za.fsf@oblong.com> <87zkqvnbu7.fsf@steelpick.2x.cz>\r
+       <m339on7nq6.fsf@oblong.com> <87mxmv4p3k.fsf@steelpick.2x.cz>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 26 Jan 2011 23:38:29 +1000\r
+Message-ID: <8762tb23ai.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 26 Jan 2011 13:38:31 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Thu, 20 Jan 2011 15:38:39 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrot=\r
+e:\r
+> On Thu, 20 Jan 2011, Andy Wingo wrote:\r
+> > Sure.  But the ccache thing is fairly common, AFAIK, and IMO notmuch's\r
+> > configure should either handle spaces in a non-absolute-path $CC or exit\r
+> > with an error in that case.\r
+\r
+Hi Andy,\r
+\r
+Thanks for pointing out the bug. I didn't notice this because I get\r
+ccache by putting a symlink in ~/bin/cc -> /usr/bin/ccache.\r
+\r
+I hadn't expected the IFS change to cause any problem like this, but\r
+there it is.\r
+\r
+> I went through configure in notmuch and it seems that there is only one\r
+> place where the value of IFS matters (the call to ldconfig), so we may\r
+> want to apply the patch bellow. On the other hand, a brief look at\r
+> Makefile reveals that there are many things that wont work if there are\r
+> spaces in filanames[1], so I'm not sure whether to care about that\r
+> single case at all.\r
+\r
+Thanks for the analysis. I've committed this change now.\r
+\r
+> [1]  For example most commands in install targets contain unquoted\r
+>      parameters so if DESTDIR contains a space, it wont work.\r
+\r
+I've run through and fixed all of these that I saw. And I did a quick\r
+test with:\r
+\r
+       make DESTDIR=3D"/tmp/bar baz" install\r
+\r
+and it at least seems to work.\r
+\r
+I agree that this kind of thing is probably not likely to happen\r
+often. But since I did decide to invent my own build system, I feel I\r
+have an obligation to make it as "correct" as possible.\r
+\r
+=2DCarl\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFNQCPV6JDdNq8qSWgRAiYnAKCNMtMjVs069slYYaLca8kIdnB8BgCdHkAI\r
+GmPYvBcvKNxOcVggcNJnQpU=\r
+=KBEy\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r