Re: [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer, makes it read...

diff --git a/1b/461f27d76b1f9912c63012e2278bfe7944b5a5 b/1b/461f27d76b1f9912c63012e2278bfe7944b5a5
new file mode 100644 (file)
index 0000000..5f08738
--- /dev/null
+++ b/1b/461f27d76b1f9912c63012e2278bfe7944b5a5
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F3CF86DE13DB\r
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 04:55:41 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.306\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.306 tagged_above=-999 required=5 tests=[AWL=0.245,\r
+  RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id BF-y4teXqHdL for <notmuch@notmuchmail.org>;\r
+ Mon, 23 Nov 2015 04:55:40 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 44B376DE13DA\r
+ for <notmuch@notmuchmail.org>; Mon, 23 Nov 2015 04:55:40 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1a0qeh-0000Xr-2w; Mon, 23 Nov 2015 07:55:39 -0500\r
+Received: (nullmailer pid 8922 invoked by uid 1000);\r
+ Mon, 23 Nov 2015 12:55:38 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Cc: tomi.ollila@iki.fi\r
+Subject: Re: [PATCH 1/4] emacs: notmuch-show-view-raw-message clears buffer,\r
+ makes it read-only\r
+In-Reply-To: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1441204482-26509-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 23 Nov 2015 08:55:38 -0400\r
+Message-ID: <87fuzw50z9.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 23 Nov 2015 12:55:42 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> notmuch-show-view-raw-message() re-uses buffer created with same\r
+> name (same Message-Id:) but it did not erase it before filling.\r
+> If this ever happened, there were duplicated (potentially overlapping)\r
+> content in the buffer. Now this is fixed.\r
+> Apparently since emacs 24.5 the (view-buffer) makes the buffer read-only;\r
+> so this problem would not have happened there, just that\r
+> notmuch-show-view-raw-message() failed. This is fixed by setting\r
+> inhibit-read-only t before erasing and filling the buffer. The emacs 24.5\r
+> feature having raw message buffer read-only is also now explicitly set to\r
+> the buffer so the same experience is available with emaces < 24.5.\r
+\r
+Applied this one patch to master\r
+\r
+d\r