Bug #250212 - Add a new 'upstream.workaround' qa category, and use it for

the EMakeParallelDisabled check. Thanks to Mike Auty <ikelos@g.o> for this
patch. (trunk r12179)

svn path=/main/branches/2.1.6/; revision=12215

diff --git a/bin/repoman b/bin/repoman
index da3e4fcdf5c1a02f968fff53090d20ec854c97c5..4139713542376303f419b2ca3ddadf3e817bf364 100755 (executable)
--- a/bin/repoman
+++ b/bin/repoman
@@ -314,7 +314,8 @@ qahelp={
        "virtual.versioned":"PROVIDE contains virtuals with versions",
        "virtual.exists":"PROVIDE contains existing package names",
        "virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",
-       "usage.obsolete":"The ebuild makes use of an obsolete construct"
+       "usage.obsolete":"The ebuild makes use of an obsolete construct",
+       "upstream.workaround":"The ebuild works around an upstream bug, an upstream bug should be filed and tracked in bugs.gentoo.org"
 }
 
 qacats = qahelp.keys()
@@ -350,6 +351,7 @@ qawarnings = set((
 "virtual.exists",
 "virtual.unavailable",
 "usage.obsolete",
+"upstream.workaround",
 "LIVEVCS.stable"
 ))
 

diff --git a/man/repoman.1 b/man/repoman.1
index 48a18986f2b1f3cdd614f189bb919fdf244a7162..d6f196e018da09eb2857acdd8c778706247d5d93 100644 (file)
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -263,6 +263,10 @@ Bad metadata.xml files
 .B metadata.missing
 Missing metadata.xml files
 .TP
+.B upstream.workaround
+The ebuild works around an upstream bug, an upstream bug should be filed and
+tracked in bugs.gentoo.org
+.TP
 .B usage.obsolete
 The ebuild makes use of an obsolete construct
 .TP

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index c9415b759b2936786beff1b38679f92f46fb94bc..c90b54f7bbcd8f3d778758c2ba649f9bb5ba1333 100644 (file)
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -291,7 +291,7 @@ class IUseUndefined(LineCheck):
 
 class EMakeParallelDisabled(LineCheck):
        """Check for emake -j1 calls which disable parallelization."""
-       repoman_check_name = 'ebuild.minorsyn'
+       repoman_check_name = 'upstream.workaround'
        re = re.compile(r'^\s*emake\s+-j\s*1\s')
        error = errors.EMAKE_PARALLEL_DISABLED
 

diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index 7c54cc13d9982c013cc9130932c58cbe2dab27a8..7f45bea21b949596d57045fa4cf1a44fb874f589 100644 (file)
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -13,5 +13,5 @@ MISSING_QUOTES_ERROR = 'Unquoted Variable on line: %d'
 NESTED_DIE_ERROR = 'Ebuild calls die in a subshell on line: %d'
 PATCHES_ERROR = 'PATCHES is not a bash array on line: %d'
 REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
-EMAKE_PARALLEL_DISABLED = 'Ebuild calls emake -j1 on line: %d'
+EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'