Re: [PATCH] emacs: Fontify From with message-header-other

diff --git a/3c/4098cebce55a7735c0b60062dbce415c407dbb b/3c/4098cebce55a7735c0b60062dbce415c407dbb
new file mode 100644 (file)
index 0000000..101410f
--- /dev/null
+++ b/3c/4098cebce55a7735c0b60062dbce415c407dbb
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 6864E6DE1744\r
+ for <notmuch@notmuchmail.org>; Fri,  6 Nov 2015 07:31:41 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.733\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.733 tagged_above=-999 required=5 tests=[AWL=0.081, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id k4o80773mhQq for <notmuch@notmuchmail.org>;\r
+ Fri,  6 Nov 2015 07:31:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 1209A6DE1502\r
+ for <notmuch@notmuchmail.org>; Fri,  6 Nov 2015 07:31:39 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 3EBAB10005A;\r
+ Fri,  6 Nov 2015 17:31:39 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: "H. J. Illikainen" <hji@dyntopia.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Fontify From with message-header-other\r
+In-Reply-To: <1446677040-43496-1-git-send-email-hji@dyntopia.com>\r
+References: <1446677040-43496-1-git-send-email-hji@dyntopia.com>\r
+User-Agent: Notmuch/0.21+14~g053baf4 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 06 Nov 2015 17:31:38 +0200\r
+Message-ID: <m2lhab87qd.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 06 Nov 2015 15:31:41 -0000\r
+\r
+On Thu, Nov 05 2015, "H. J. Illikainen" <hji@dyntopia.com> wrote:\r
+\r
+> Commit e26d767897e8ab59f05808a12ac5c9c1e3c7030f changed the\r
+> fontification of the body associated with the From header to\r
+> message-header-from.  However, that face is non-existent, and in\r
+> message.el (message-font-lock-keywords) the From-header falls through\r
+> and is attributed the message-header-other face.\r
+>\r
+> This commit removes the fontification of the [Ff]rom header in\r
+> notmuch-show-mode in order to fontify it using the message-header-other\r
+> face.\r
+>\r
+> This only affects non-default configurations where\r
+> notmuch-message-headers is set to display From.\r
+\r
+I grepped emacs 24.3 sources for message-header-subject and\r
+message-header-from and, indeed, there is not reference to \r
+message-header-from (but plenty of message-header-subject).\r
+\r
+So, to me this change looks good (and trivial) -- I have not\r
+tested it (yet), though.\r
+\r
+Tomi\r
+\r
+> ---\r
+>  emacs/notmuch-show.el | 2 --\r
+>  1 file changed, 2 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 49fd198..793f1a5 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -353,8 +353,6 @@ operation on the contents of the current buffer."\r
+>              'message-header-cc)\r
+>             ((looking-at "[Ss]ubject:")\r
+>              'message-header-subject)\r
+> -           ((looking-at "[Ff]rom:")\r
+> -            'message-header-from)\r
+>             (t\r
+>              'message-header-other))))\r
+>  \r
+> -- \r
+> H. J. Illikainen\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> https://notmuchmail.org/mailman/listinfo/notmuch\r