[PATCH] configure: Add sanity checking for environment variables

diff --git a/5f/6453b412db4a78f1180c3663cf85e131082669 b/5f/6453b412db4a78f1180c3663cf85e131082669
new file mode 100644 (file)
index 0000000..0bd4b84
--- /dev/null
+++ b/5f/6453b412db4a78f1180c3663cf85e131082669
@@ -0,0 +1,114 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 274616DE137E\r
+ for <notmuch@notmuchmail.org>; Tue, 19 May 2015 13:54:59 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.3 tagged_above=-999 required=5 tests=[AWL=0.290,\r
+ T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Uji9Xiw_BS80 for <notmuch@notmuchmail.org>;\r
+ Tue, 19 May 2015 13:54:57 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 4230F6DE10F8\r
+ for <notmuch@notmuchmail.org>; Tue, 19 May 2015 13:54:56 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.80) (envelope-from <bremner@tesseract.cs.unb.ca>)\r
+ id 1YuoVn-0001Py-6M; Tue, 19 May 2015 20:53:15 +0000\r
+Received: (nullmailer pid 26675 invoked by uid 1000); Tue, 19 May 2015\r
+ 20:52:14 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Ronny Chevalier <chevalier.ronny@gmail.com>, David Bremner\r
+ <david@tethera.net>\r
+Subject: [PATCH] configure: Add sanity checking for environment variables\r
+Date: Tue, 19 May 2015 22:52:08 +0200\r
+Message-Id: <1432068728-26587-1-git-send-email-david@tethera.net>\r
+X-Mailer: git-send-email 2.1.4\r
+In-Reply-To:\r
+ <CABPZE7+zDwFj7Y1OMU0DVwpwUedK6qUZLQcKEZTMNdRr0A=NeQ@mail.gmail.com>\r
+References:\r
+ <CABPZE7+zDwFj7Y1OMU0DVwpwUedK6qUZLQcKEZTMNdRr0A=NeQ@mail.gmail.com>\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 19 May 2015 20:54:59 -0000\r
+\r
+Passing in environment variables incompatible with the compiler may\r
+cause other parts of the configure script to fail in hard to\r
+understand ways, so we abort early.\r
+---\r
+\r
+This doesn't actually fix the problem Ronny points out, but a more\r
+serious one where configure can actually fail when using gcc, if\r
+e.g. nonsense is passed in CFLAGS.\r
+\r
+ configure | 30 ++++++++++++++++++++++++++++--\r
+ 1 file changed, 28 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/configure b/configure\r
+index 4af7ba9..cf618e8 100755\r
+--- a/configure\r
++++ b/configure\r
+@@ -269,6 +269,34 @@ dependencies are available:\r
+ EOF\r
+ \r
+ errors=0\r
++printf "int main(void){return 0;}\n" > minimal.c\r
++\r
++printf "Sanity checking C compilation environment... "\r
++if ${CC} ${CFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1\r
++then\r
++    printf "Ok.\n"\r
++else\r
++    printf "Fail.\n"\r
++    errors=$((errors + 1))\r
++fi\r
++\r
++printf "Sanity checking C++ compilation environment... "\r
++if ${CXX} ${CXXFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1\r
++then\r
++    printf "Ok.\n"\r
++else\r
++    printf "Fail.\n"\r
++    errors=$((errors + 1))\r
++fi\r
++\r
++if [ $errors -gt 0 ]; then\r
++    cat <<EOF\r
++*** Error: Initial sanity checking of environment failed.  Please try\r
++running configure in a clean environment, and if the problem persists,\r
++report a bug.\r
++EOF\r
++    exit 1\r
++fi\r
+ \r
+ if pkg-config --version > /dev/null 2>&1; then\r
+     have_pkg_config=1\r
+@@ -690,8 +718,6 @@ else\r
+ fi\r
+ rm -f compat/check_asctime\r
+ \r
+-printf "int main(void){return 0;}\n" > minimal.c\r
+-\r
+ printf "Checking for rpath support... "\r
+ if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1\r
+ then\r
+-- \r
+2.1.4\r
+\r