mail: handle unicode in subject for python3
authorZac Medico <zmedico@gentoo.org>
Fri, 18 Feb 2011 08:03:10 +0000 (00:03 -0800)
committerZac Medico <zmedico@gentoo.org>
Sun, 20 Feb 2011 00:01:38 +0000 (16:01 -0800)
pym/portage/mail.py

index f87efe2623b9f1e62b5ecd93364538fe88e95454..598c1f9b74d86ade9e7729b9d3bb2c394aafde8d 100644 (file)
@@ -67,9 +67,19 @@ def create_message(sender, recipient, subject, body, attachments=None):
        mymessage.set_unixfrom(sender)
        mymessage["To"] = recipient
        mymessage["From"] = sender
-       # Use Header as a workaround so that long subject lines are wrapped
-       # correctly by <=python-2.6 (gentoo bug #263370, python issue #1974).
-       mymessage["Subject"] = Header(subject)
+
+       if sys.hexversion >= 0x3000000:
+               # Avoid UnicodeEncodeError in python3 with non-ascii characters.
+               #  File "/usr/lib/python3.1/email/header.py", line 189, in __init__
+               #    self.append(s, charset, errors)
+               #  File "/usr/lib/python3.1/email/header.py", line 262, in append
+               #    input_bytes = s.encode(input_charset, errors)
+               #UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-9: ordinal not in range(128)
+               mymessage["Subject"] = subject
+       else:
+               # Use Header as a workaround so that long subject lines are wrapped
+               # correctly by <=python-2.6 (gentoo bug #263370, python issue #1974).
+               mymessage["Subject"] = Header(subject)
        mymessage["Date"] = time.strftime("%a, %d %b %Y %H:%M:%S %z")
        
        return mymessage