Re: [PATCH 4/4] cli: add standard option processing to config and setup

diff --git a/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131 b/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131
new file mode 100644 (file)
index 0000000..2f9ba94
--- /dev/null
+++ b/0c/f0f1c30f47bdc1e5c8c725c5245c2bff834131
@@ -0,0 +1,77 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 43E066DE1B5C\r
+ for <notmuch@notmuchmail.org>; Sun,  5 Apr 2015 14:35:44 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.602\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.602 tagged_above=-999 required=5 tests=[AWL=0.602]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id dfGQiBSS8be4 for <notmuch@notmuchmail.org>;\r
+ Sun,  5 Apr 2015 14:35:41 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 928DB6DE1997\r
+ for <notmuch@notmuchmail.org>; Sun,  5 Apr 2015 14:35:41 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.80) (envelope-from <david@tethera.net>)\r
+ id 1YesCD-0002Ys-M3; Sun, 05 Apr 2015 21:35:09 +0000\r
+Received: (nullmailer pid 19461 invoked by uid 1000); Sun, 05 Apr 2015\r
+ 21:34:52 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/4] cli: add standard option processing to config and\r
+ setup\r
+In-Reply-To: <1428267574-28797-5-git-send-email-david@tethera.net>\r
+References: <1428267574-28797-1-git-send-email-david@tethera.net>\r
+ <1428267574-28797-5-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 06 Apr 2015 06:34:52 +0900\r
+Message-ID: <87d23ixnr7.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Apr 2015 21:35:44 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> In particular this fixes a recently encountered bug where the\r
+> "--config" argument to "notmuch setup" is silently ignored, which the\r
+> unpleasant consequence of overwriting the users config file.\r
+\r
+Urgh. I had a longish cover letter for this series but somehow mashing\r
+buttons with git-send-email caused it to be lost forever. Or maybe it's\r
+en route still. Anyway, here is a quick summary:\r
+\r
+- The first two patches are worthwhile just to improve understandability\r
+  IMHO\r
+\r
+- The third patch is a bit big for tiny improvement in functionality,\r
+  but it does make it easier to define global arguments, which is\r
+  something I want for the revision-tracking series\r
+  (id:1413181203-1676-1-git-send-email-aclements@csail.mit.edu)\r
+\r
+- the last patch fixes an annoying bug where --config is silently\r
+  ignored in\r
+\r
+  % notmuch setup --config=foobar\r
+\r
+  This could of course be fixed in a way that doesn't depend on patch\r
+  3/4.\r