[PATCH] emacs: Don't use nconc on quoted list

diff --git a/4d/50c079ded3986e4a7ae577364fed03d9feac0d b/4d/50c079ded3986e4a7ae577364fed03d9feac0d
new file mode 100644 (file)
index 0000000..0cd49bf
--- /dev/null
+++ b/4d/50c079ded3986e4a7ae577364fed03d9feac0d
@@ -0,0 +1,84 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 0FD0B6DE103A\r
+ for <notmuch@notmuchmail.org>; Wed,  6 Jan 2016 13:29:01 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.849\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.849 tagged_above=-999 required=5 tests=[AWL=1.021,\r
+  RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,\r
+ RP_MATCHES_RCVD=-0.55] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id oeEbn6UWq7UA for <notmuch@notmuchmail.org>;\r
+ Wed,  6 Jan 2016 13:28:59 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 2D7396DE1003\r
+ for <notmuch@notmuchmail.org>; Wed,  6 Jan 2016 13:28:59 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.7])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id 7688519F4644;\r
+ Wed,  6 Jan 2016 22:28:58 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+ by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10044)\r
+ with ESMTP id hV_iw7wpqROL; Wed,  6 Jan 2016 22:28:56 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+ by max.feld.cvut.cz (Postfix) with ESMTP id D6A2519F41E2;\r
+ Wed,  6 Jan 2016 22:28:56 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.86)\r
+ (envelope-from <sojkam1@fel.cvut.cz>)\r
+ id 1aGvdY-00057g-Fi; Wed, 06 Jan 2016 22:28:56 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: David Bremner <david@tethera.net>,\r
+       notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: Don't use nconc on quoted list\r
+Date: Wed,  6 Jan 2016 22:28:45 +0100\r
+Message-Id: <1452115725-19650-1-git-send-email-sojkam1@fel.cvut.cz>\r
+X-Mailer: git-send-email 2.6.4\r
+In-Reply-To: <87ziwiv1nx.fsf@steelpick.2x.cz>\r
+References: <87ziwiv1nx.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: 8bit\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 06 Jan 2016 21:29:01 -0000\r
+\r
+As pointed out by David Bremner, Elisp manual says "A common pitfall\r
+is to use a quoted constant list as a non-last argument to ‘nconc’."\r
+Since this was the case in recently added code, we fix it here.\r
+---\r
+ emacs/notmuch-mua.el | 4 ++--\r
+ 1 file changed, 2 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+index 45a6daa..5462f54 100644\r
+--- a/emacs/notmuch-mua.el\r
++++ b/emacs/notmuch-mua.el\r
+@@ -322,8 +322,8 @@ modified. This function is notmuch addaptation of\r
+   (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)\r
+                            (or switch-function (notmuch-mua-get-switch-function)))\r
+   (let ((headers\r
+-       ;; The following sexp is copied from `message-mail'\r
+-       (nconc\r
++       (append\r
++        ;; The following is copied from `message-mail'\r
+         `((To . ,(or to "")) (Subject . ,(or subject "")))\r
+         ;; C-h f compose-mail says that headers should be specified as\r
+         ;; (string . value); however all the rest of message expects\r
+-- \r
+2.6.4\r
+\r